Bug 176181 - Remove newBlockInsideInlineModel and anonymous inline block
Summary: Remove newBlockInsideInlineModel and anonymous inline block
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-31 13:23 PDT by Antti Koivisto
Modified: 2017-09-27 12:59 PDT (History)
9 users (show)

See Also:


Attachments
patch (53.71 KB, patch)
2017-08-31 13:28 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (79.37 KB, patch)
2017-08-31 14:16 PDT, Antti Koivisto
zalan: review+
Details | Formatted Diff | Diff
patch (79.60 KB, patch)
2017-08-31 14:43 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-08-31 13:23:28 PDT
Anonymous inline block exists to support newBlockInsideInlineModel which was planned to replace continuations. It has never been enabled and it is time to remove it.
Comment 1 Antti Koivisto 2017-08-31 13:28:14 PDT
Created attachment 319511 [details]
patch
Comment 2 Antti Koivisto 2017-08-31 14:16:48 PDT
Created attachment 319521 [details]
patch
Comment 3 Build Bot 2017-08-31 14:18:54 PDT
Attachment 319521 [details] did not pass style-queue:


ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1421:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2017-08-31 14:43:19 PDT
Created attachment 319525 [details]
patch
Comment 5 WebKit Commit Bot 2017-08-31 16:27:07 PDT
Comment on attachment 319525 [details]
patch

Clearing flags on attachment: 319525

Committed r221456: <http://trac.webkit.org/changeset/221456>
Comment 6 WebKit Commit Bot 2017-08-31 16:27:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Don Olmstead 2017-08-31 18:49:16 PDT
This broke AppleWin and WinCairo is having the same issues.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:59:53 PDT
<rdar://problem/34694451>