Bug 176164 - Take into account removed caches in Caches::remove assertion
Summary: Take into account removed caches in Caches::remove assertion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-31 09:34 PDT by youenn fablet
Modified: 2017-09-27 12:46 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.17 KB, patch)
2017-08-31 10:48 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-08-31 09:34:53 PDT 
Caches may be asked to remove an already removed cache.
The assertion in Caches::remove should take that into account.
Comment 1 youenn fablet 2017-08-31 10:48:22 PDT 
Created attachment 319479 [details]
Patch
Comment 2 Build Bot 2017-08-31 10:50:53 PDT 
Attachment 319479 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:131:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-08-31 11:31:26 PDT 
Comment on attachment 319479 [details]
Patch

Clearing flags on attachment: 319479

Committed r221428: <http://trac.webkit.org/changeset/221428>
Comment 4 WebKit Commit Bot 2017-08-31 11:31:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Matt Lewis 2017-09-01 15:39:24 PDT 
The test added in this patch has consistently failed on windows testers since being added according to the flakiness dashboard.

it has also failed on Sierra debug:
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r221490%20(2818)/results.html
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:46:47 PDT 
<rdar://problem/34693934>