Bug 176163 - [Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests.
Summary: [Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-31 08:07 PDT by Per Arne Vollan
Modified: 2017-09-27 12:47 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.44 KB, patch)
2017-08-31 08:15 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-08-31 08:07:00 PDT 
My previous attempt at fixing this crash in <http://trac.webkit.org/changeset/221323> was incorrect, since it is still crashing on the bot(s). The current theory of why this is failing is that the WorkQueue object deletes itself in the middle of the performWorkOnRegisteredWorkThread method when calling deref().
Comment 1 Per Arne Vollan 2017-08-31 08:15:40 PDT 
Created attachment 319462 [details]
Patch
Comment 2 Per Arne Vollan 2017-08-31 10:47:20 PDT 
Comment on attachment 319462 [details]
Patch

Thanks for reviewing!
Comment 3 WebKit Commit Bot 2017-08-31 11:15:51 PDT 
Comment on attachment 319462 [details]
Patch

Clearing flags on attachment: 319462

Committed r221425: <http://trac.webkit.org/changeset/221425>
Comment 4 WebKit Commit Bot 2017-08-31 11:15:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:47:10 PDT 
<rdar://problem/34693984>