Bug 176148 - Add support for Request body stream cloning
Summary: Add support for Request body stream cloning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-30 21:29 PDT by youenn fablet
Modified: 2017-09-27 12:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (52.59 KB, patch)
2017-08-30 22:14 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (53.27 KB, patch)
2017-08-31 12:33 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-08-30 21:29:51 PDT 
Add support for Request body stream cloning
Comment 1 youenn fablet 2017-08-30 22:14:51 PDT 
Created attachment 319452 [details]
Patch
Comment 2 Alex Christensen 2017-08-31 10:57:32 PDT 
Comment on attachment 319452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319452&action=review

> Source/WebCore/Modules/fetch/FetchBodySource.cpp:2
> + * Copyright (C) 2016 Canon Inc.

Did you write this last year?

> Source/WebCore/Modules/fetch/FetchBodySource.cpp:13
> + * 3.  Neither the name of Canon Inc. nor the names of

I think the copyright should only have two terms.
Comment 3 youenn fablet 2017-08-31 11:03:15 PDT 
Thanks for the review.

(In reply to Alex Christensen from comment #2)
> Comment on attachment 319452 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319452&action=review
> 
> > Source/WebCore/Modules/fetch/FetchBodySource.cpp:2
> > + * Copyright (C) 2016 Canon Inc.
> 
> Did you write this last year?

Yes.
Maybe I should also add Apple Copyright.

> > Source/WebCore/Modules/fetch/FetchBodySource.cpp:13
> > + * 3.  Neither the name of Canon Inc. nor the names of
> 
> I think the copyright should only have two terms.

OK.
Comment 4 youenn fablet 2017-08-31 12:33:13 PDT 
Created attachment 319499 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-08-31 13:03:46 PDT 
Comment on attachment 319499 [details]
Patch for landing

Clearing flags on attachment: 319499

Committed r221437: <http://trac.webkit.org/changeset/221437>
Comment 6 WebKit Commit Bot 2017-08-31 13:03:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:50:42 PDT 
<rdar://problem/34694127>