Bug 176140 – REGRESSION(r221226): [SOUP] libsoup-CRITICAL **: soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Charlie noticed this error in the buildbot logs:

libsoup-CRITICAL **: soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed

I bet it's a regression from r221226.

[Michael Catanzaro]

Created attachment 319429 [details]
Patch

[Michael Catanzaro]

This is a speculative fix, but I'm fairly confident....

[Carlos Garcia Campos]

Comment on attachment 319429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319429&action=review

> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:92
> -    bool didAccessSecureCookies = false;
> +    if (!cookies)
> +        return { { }, false };
>  
> +    bool didAccessSecureCookies = false;

I think it would be better to do this check after the loop. If all cookies are secure and includeSecureCookies == IncludeSecureCookies::No, the list can be empty (nullptr) after the loop.

[Charlie Turner]

Michael, your speculative fix has worked for me, thanks!

[Michael Catanzaro]

(In reply to Carlos Garcia Campos from comment #3)
> I think it would be better to do this check after the loop. If all cookies
> are secure and includeSecureCookies == IncludeSecureCookies::No, the list
> can be empty (nullptr) after the loop.

Good catch.

[Michael Catanzaro]

Committed r221438: <http://trac.webkit.org/changeset/221438>