Do not create a salt if the CacheStorage engine should not persist

[youenn fablet]

There is no need for a salt if there is no access to the disk

[youenn fablet]

Created attachment 319428 [details]
Patch

[Alex Christensen]

Comment on attachment 319428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319428&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCacheData.h:-108
> -Salt makeSalt();

Won't we just need to put this back when we make persistent caches use salts?

[youenn fablet]

Thanks for the review.

(In reply to Alex Christensen from comment #2)
> Comment on attachment 319428 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319428&action=review
> 
> > Source/WebKit/NetworkProcess/cache/NetworkCacheData.h:-108
> > -Salt makeSalt();
> 
> Won't we just need to put this back when we make persistent caches use salts?

For persistent cache salts, we have readOrMakeSalt.

[WebKit Commit Bot]

Comment on attachment 319428 [details]
Patch

Clearing flags on attachment: 319428

Committed r221426: <http://trac.webkit.org/changeset/221426>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693860>