Bug 176128 - WKNavigationDelegatePrivate client redirect SPI needs to be able to detect redirects scheduled before the document finishes loading
Summary: WKNavigationDelegatePrivate client redirect SPI needs to be able to detect re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-30 15:17 PDT by David Quesada
Modified: 2017-08-31 14:26 PDT (History)
7 users (show)

See Also:


Attachments
Patch v1 (30.86 KB, patch)
2017-08-30 15:56 PDT, David Quesada
beidson: review+
Details | Formatted Diff | Diff
Patch v2 (30.86 KB, patch)
2017-08-31 10:31 PDT, David Quesada
beidson: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
v3 (31.79 KB, patch)
2017-08-31 12:03 PDT, David Quesada
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Quesada 2017-08-30 15:17:26 PDT
rdar://problem/34068476
Comment 1 Radar WebKit Bug Importer 2017-08-30 15:18:43 PDT
<rdar://problem/34173692>
Comment 2 David Quesada 2017-08-30 15:56:19 PDT
Created attachment 319416 [details]
Patch v1
Comment 3 Brady Eidson 2017-08-31 10:10:11 PDT
Comment on attachment 319416 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=319416&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:325
>      webPage->injectedBundleLoaderClient().willPerformClientRedirectForFrame(*webPage, *m_frame, url, interval, fireDate);
> +
> +    // Notify the UIProcess.
> +    webPage->send(Messages::WebPageProxy::DidScheduleClientRedirectForFrame(m_frame->frameID(), url.string(), interval));

Why the different names?
Comment 4 David Quesada 2017-08-31 10:16:59 PDT
(In reply to Brady Eidson from comment #3)
> Comment on attachment 319416 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319416&action=review
> 
> > Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:325
> >      webPage->injectedBundleLoaderClient().willPerformClientRedirectForFrame(*webPage, *m_frame, url, interval, fireDate);
> > +
> > +    // Notify the UIProcess.
> > +    webPage->send(Messages::WebPageProxy::DidScheduleClientRedirectForFrame(m_frame->frameID(), url.string(), interval));
> 
> Why the different names?

I think I meant to rename to 'willPerform' to be consistent but didn't get around to it. I'll rename it.
Comment 5 David Quesada 2017-08-31 10:31:53 PDT
Created attachment 319474 [details]
Patch v2
Comment 6 WebKit Commit Bot 2017-08-31 11:21:34 PDT
Comment on attachment 319474 [details]
Patch v2

Rejecting attachment 319474 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 319474, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.webkit.org/git/WebKit
   cc798d2..7719687  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 221425 = cc798d25c577d89d7f1da0d0228725ae19ff2952
r221426 = 7719687905e06b12cc8e23043552456d657754d8
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/4417728
Comment 7 David Quesada 2017-08-31 12:03:38 PDT
Created attachment 319495 [details]
v3

Basically the same as v2, but rebased, updated the dates in the changelog, and used git-format-patch
Comment 8 WebKit Commit Bot 2017-08-31 14:26:28 PDT
Comment on attachment 319495 [details]
v3

Clearing flags on attachment: 319495

Committed r221444: <http://trac.webkit.org/changeset/221444>
Comment 9 WebKit Commit Bot 2017-08-31 14:26:30 PDT
All reviewed patches have been landed.  Closing bug.