rdar://problem/34068476
<rdar://problem/34173692>
Created attachment 319416 [details] Patch v1
Comment on attachment 319416 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=319416&action=review > Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:325 > webPage->injectedBundleLoaderClient().willPerformClientRedirectForFrame(*webPage, *m_frame, url, interval, fireDate); > + > + // Notify the UIProcess. > + webPage->send(Messages::WebPageProxy::DidScheduleClientRedirectForFrame(m_frame->frameID(), url.string(), interval)); Why the different names?
(In reply to Brady Eidson from comment #3) > Comment on attachment 319416 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319416&action=review > > > Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:325 > > webPage->injectedBundleLoaderClient().willPerformClientRedirectForFrame(*webPage, *m_frame, url, interval, fireDate); > > + > > + // Notify the UIProcess. > > + webPage->send(Messages::WebPageProxy::DidScheduleClientRedirectForFrame(m_frame->frameID(), url.string(), interval)); > > Why the different names? I think I meant to rename to 'willPerform' to be consistent but didn't get around to it. I'll rename it.
Created attachment 319474 [details] Patch v2
Comment on attachment 319474 [details] Patch v2 Rejecting attachment 319474 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 319474, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .webkit.org/git/WebKit cc798d2..7719687 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 221425 = cc798d25c577d89d7f1da0d0228725ae19ff2952 r221426 = 7719687905e06b12cc8e23043552456d657754d8 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/4417728
Created attachment 319495 [details] v3 Basically the same as v2, but rebased, updated the dates in the changelog, and used git-format-patch
Comment on attachment 319495 [details] v3 Clearing flags on attachment: 319495 Committed r221444: <http://trac.webkit.org/changeset/221444>
All reviewed patches have been landed. Closing bug.