This is part of changes for https://bugs.webkit.org/show_bug.cgi?id=175969. We should create a separate initSyncers() method in BuildbotTriggerable, which would initialize all BuildbotSyncer. This method could later be updated to support Buildbot 0.9.
Created attachment 319404 [details] Proposed patch
Comment on attachment 319404 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=319404&action=review > Websites/perf.webkit.org/server-tests/tools-buildbot-triggerable-tests.js:40 > + syncPromise = triggerable.initSyncers().then(() => { > + return triggerable.syncOnce(); > + }); Please just do: triggerable.initSyncers().then(() => triggerable.syncOnce()) here and elsewhere. There's no need in adding the boilerplate of { return ~ }. > Websites/perf.webkit.org/tools/js/buildbot-triggerable.js:35 > + return new Promise((resolve, reject) => { > + this._syncers = BuildbotSyncer._loadConfig(this._buildbotRemote, this._config); > + resolve(); > + }); This would resolve the promise right away. In order to test your change, we need to do something like: setTimeout(resolve, 0); or: Promise.resolve().then(() => this._syncers = BuildbotSyncer._loadConfig(this._buildbotRemote, this._config))
Comment on attachment 319404 [details] Proposed patch r=me provided those two issues are addressed.
Created attachment 320071 [details] Patch for landing
Comment on attachment 320071 [details] Patch for landing Clearing flags on attachment: 320071 Committed r221717: <http://trac.webkit.org/changeset/221717>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34694048>