NEW 176122
Layout Test media/video-controls-drop-and-restore-timeline.html is flaky. 
https://bugs.webkit.org/show_bug.cgi?id=176122
Summary Layout Test media/video-controls-drop-and-restore-timeline.html is flaky.
Matt Lewis
Reported 2017-08-30 13:26:15 PDT
media/video-controls-drop-and-restore-timeline.html is a flaky failure according to the flakiness dashboard. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-controls-drop-and-restore-timeline.html The test has in the past failed with multiple media tests, but has since also started to fail on its own. The multiple failures are seen in bug: https://bugs.webkit.org/show_bug.cgi?id=173978 The test will intermittently fail on all macOS WK2 testers. current build: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r221386%20(3951)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/3951 Diff: --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-controls-drop-and-restore-timeline-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-controls-drop-and-restore-timeline-actual.txt @@ -4,14 +4,14 @@ EXPECTED (video.controls != 'null') OK EVENT(canplaythrough) EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK -EXPECTED (timelineContainer = mediaControlsElement(shadowRoot.firstChild, "-webkit-media-controls-timeline-container") != 'null') OK +EXPECTED (timelineContainer = mediaControlsElement(shadowRoot.firstChild, "-webkit-media-controls-timeline-container") != 'null'), OBSERVED 'null' FAIL Initital test at width = 200px EXPECTED (video.offsetWidth == '200') OK -EXPECTED (timelineChildrenAreDropped() == 'true') OK -EXPECTED (timelineChildrenAreNotDisplayed() == 'true') OK +TypeError: null is not an object (evaluating 'timelineContainer.children') +TypeError: null is not an object (evaluating 'timelineContainer.children') Second test at width = 500px EXPECTED (video.offsetWidth == '500') OK -EXPECTED (timelineChildrenAreDropped() == 'false') OK -EXPECTED (timelineChildrenAreNotDisplayed() == 'false') OK +TypeError: null is not an object (evaluating 'timelineContainer.children') +TypeError: null is not an object (evaluating 'timelineContainer.children') END OF TEST
Attachments
Add attachment proposed patch, testcase, etc.
Matt Lewis
Comment 1 2017-09-07 14:53:37 PDT
Marked as flaky in Mac WK2: https://trac.webkit.org/changeset/221759/webkit
Note You need to log in before you can comment on or make changes to this bug.