Stop using PolicyCallback
Created attachment 319324 [details] Patch
Comment on attachment 319324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319324&action=review > Source/WebCore/loader/PolicyChecker.cpp:-184 > m_frame.loader().client().cancelPolicyCheck(); > - PolicyCallback callback = WTFMove(m_callback); > - callback.cancel(); Cancelling the callback is now the responsibility of the FrameLoaderClient, to whom we have given the lambda. That is why there are changes in WebKit and WebKitLegacy where the FrameLoaderClient::cancelPolicyCheck finds the lambda it has stored.
Created attachment 319378 [details] Patch
Comment on attachment 319378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319378&action=review > Source/WebCore/loader/PolicyChecker.cpp:147 > + ResourceRequest requestCopy = request; > + m_frame.loader().client().dispatchDecidePolicyForNavigationAction(action, request, didReceiveRedirectResponse, formState, [this, function = WTFMove(function), request = WTFMove(requestCopy), formState = makeRefPtr(formState), suggestedFilename = WTFMove(suggestedFilename)](PolicyAction policyAction) mutable { You can just capture request by value instead of explicitly making a copy.
Created attachment 319513 [details] Patch
Comment on attachment 319513 [details] Patch Rejecting attachment 319513 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 319513, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/4418705
Created attachment 321750 [details] Patch
Created attachment 321757 [details] Patch
http://trac.webkit.org/r222472
<rdar://problem/34694436>
*** Bug 175913 has been marked as a duplicate of this bug. ***