176087 – [Mac] Upstream Carbon-related WebKitSystemInterface functions

RESOLVED FIXED 176087

[Mac] Upstream Carbon-related WebKitSystemInterface functions

https://bugs.webkit.org/show_bug.cgi?id=176087

Summary [Mac] Upstream Carbon-related WebKitSystemInterface functions

Andy Estes

Reported 2017-08-29 19:21:03 PDT

[Mac] Upstream Carbon-related WebKitSystemInterface functions

Attachments
Patch (52.60 KB, patch) 2017-08-29 19:25 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (52.66 KB, patch) 2017-08-29 21:04 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (55.66 KB, patch) 2017-08-29 21:26 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (55.69 KB, patch) 2017-08-29 22:19 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (55.77 KB, patch) 2017-08-30 00:09 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (55.82 KB, patch) 2017-08-30 00:40 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2017-08-29 19:25:08 PDT Comment hidden (obsolete)

Created attachment 319323 [details] Patch

Build Bot

Comment 2 2017-08-29 19:26:40 PDT Comment hidden (obsolete)

Attachment 319323 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 3 2017-08-29 21:04:26 PDT Comment hidden (obsolete)

Created attachment 319332 [details] Patch

Build Bot

Comment 4 2017-08-29 21:06:14 PDT Comment hidden (obsolete)

Attachment 319332 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 5 2017-08-29 21:26:58 PDT Comment hidden (obsolete)

Created attachment 319336 [details] Patch

Build Bot

Comment 6 2017-08-29 21:29:29 PDT Comment hidden (obsolete)

Attachment 319336 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 7 2017-08-29 22:19:22 PDT Comment hidden (obsolete)

Created attachment 319341 [details] Patch

Build Bot

Comment 8 2017-08-29 22:21:40 PDT Comment hidden (obsolete)

Attachment 319341 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 9 2017-08-30 00:09:57 PDT Comment hidden (obsolete)

Created attachment 319348 [details] Patch

Build Bot

Comment 10 2017-08-30 00:11:37 PDT Comment hidden (obsolete)

Attachment 319348 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 11 2017-08-30 00:40:58 PDT

Created attachment 319350 [details] Patch

Build Bot

Comment 12 2017-08-30 00:42:07 PDT

Attachment 319350 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 13 2017-08-30 01:59:13 PDT

Comment on attachment 319350 [details] Patch Clearing flags on attachment: 319350 Committed r221351: <http://trac.webkit.org/changeset/221351>

WebKit Commit Bot

Comment 14 2017-08-30 01:59:15 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 15 2017-08-30 02:01:43 PDT

<rdar://problem/34156936>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Andy Estes

Reported

2017-08-29 19:21 PDT

Modified

2017-08-30 02:01 PDT History

CC List

7 users Show

URL

Keywords InRadar

Depends on

Blocks