176087 – [Mac] Upstream Carbon-related WebKitSystemInterface functions

Bug 176087 - [Mac] Upstream Carbon-related WebKitSystemInterface functions

Summary: [Mac] Upstream Carbon-related WebKitSystemInterface functions

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andy Estes

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2017-08-29 19:21 PDT by Andy Estes
Modified:	2017-08-30 02:01 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (52.60 KB, patch) 2017-08-29 19:25 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (52.66 KB, patch) 2017-08-29 21:04 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (55.66 KB, patch) 2017-08-29 21:26 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (55.69 KB, patch) 2017-08-29 22:19 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (55.77 KB, patch) 2017-08-30 00:09 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (55.82 KB, patch) 2017-08-30 00:40 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andy Estes 2017-08-29 19:21:03 PDT

[Mac] Upstream Carbon-related WebKitSystemInterface functions

Comment 1 Andy Estes 2017-08-29 19:25:08 PDT Comment hidden (obsolete)

Created attachment 319323 [details]
Patch

Comment 2 Build Bot 2017-08-29 19:26:40 PDT Comment hidden (obsolete)

Attachment 319323 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 10 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Andy Estes 2017-08-29 21:04:26 PDT Comment hidden (obsolete)

Created attachment 319332 [details]
Patch

Comment 4 Build Bot 2017-08-29 21:06:14 PDT Comment hidden (obsolete)

Attachment 319332 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 10 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Andy Estes 2017-08-29 21:26:58 PDT Comment hidden (obsolete)

Created attachment 319336 [details]
Patch

Comment 6 Build Bot 2017-08-29 21:29:29 PDT Comment hidden (obsolete)

Attachment 319336 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 10 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Andy Estes 2017-08-29 22:19:22 PDT Comment hidden (obsolete)

Created attachment 319341 [details]
Patch

Comment 8 Build Bot 2017-08-29 22:21:40 PDT Comment hidden (obsolete)

Attachment 319341 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 10 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Andy Estes 2017-08-30 00:09:57 PDT Comment hidden (obsolete)

Created attachment 319348 [details]
Patch

Comment 10 Build Bot 2017-08-30 00:11:37 PDT Comment hidden (obsolete)

Attachment 319348 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 10 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 11 Andy Estes 2017-08-30 00:40:58 PDT

Created attachment 319350 [details]
Patch

Comment 12 Build Bot 2017-08-30 00:42:07 PDT

Attachment 319350 [details] did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:444:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:452:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:468:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:524:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:550:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:776:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebKitLegacy/mac/Carbon/HIWebView.mm:1357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:41:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/PAL/pal/spi/mac/QuickDrawSPI.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 10 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 13 WebKit Commit Bot 2017-08-30 01:59:13 PDT

Comment on attachment 319350 [details]
Patch

Clearing flags on attachment: 319350

Committed r221351: <http://trac.webkit.org/changeset/221351>

Comment 14 WebKit Commit Bot 2017-08-30 01:59:15 PDT

All reviewed patches have been landed.  Closing bug.

Comment 15 Radar WebKit Bug Importer 2017-08-30 02:01:43 PDT

<rdar://problem/34156936>