Bug 176082 – Implement all of "Register" right up until where the script is fetched

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Implement all of "Register" right up until where the script is fetched

This includes tests for all the exceptions that can occur along the way.

[Brady Eidson]

Created attachment 319326 [details]
EWS run

[Brady Eidson]

Created attachment 319372 [details]
Patch

[Andy Estes]

Comment on attachment 319372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319372&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:170
> +    ScopeGuard guard([this, job = &job] {

Why not just capture &job?

> Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:37
> +{
> +}

Do you need to call suspendIfNeeded() here now that this is an ActiveDOMObject?

[Brady Eidson]

(In reply to Andy Estes from comment #3)
> Comment on attachment 319372 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319372&action=review
> 
> > Source/WebCore/workers/service/ServiceWorkerContainer.cpp:170
> > +    ScopeGuard guard([this, job = &job] {
> 
> Why not just capture &job?

Oh, no reason. (Leftovers from a previous iteration of this function)

> > Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:37
> > +{
> > +}
> 
> Do you need to call suspendIfNeeded() here now that this is an
> ActiveDOMObject?

The answer is no, but simply because there is still no code path that actually ends up in properly resolving the promise with a new registration.

Once there is such a code path, I sure will!

[Brady Eidson]

Created attachment 319379 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 319379 [details]
Patch

Clearing flags on attachment: 319379

Committed r221392: <http://trac.webkit.org/changeset/221392>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34169273>