Bug 176067 - Web Inspector: Convert all methods in Utilities.js to ECMAScript 2015 shorthand syntax
Summary: Web Inspector: Convert all methods in Utilities.js to ECMAScript 2015 shortha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-29 14:39 PDT by Nikita Vasilyev
Modified: 2017-08-29 16:46 PDT (History)
4 users (show)

See Also:


Attachments
Patch (20.20 KB, patch)
2017-08-29 14:52 PDT, Nikita Vasilyev
joepeck: review+
Details | Formatted Diff | Diff
Patch (20.13 KB, patch)
2017-08-29 15:37 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-08-29 14:39:51 PDT
Convert:

    {
        value: function(object) {}
    }

to:

    {
        value(object) {}
    }
Comment 1 Nikita Vasilyev 2017-08-29 14:52:40 PDT
Created attachment 319287 [details]
Patch
Comment 2 Joseph Pecoraro 2017-08-29 15:22:39 PDT
Comment on attachment 319287 [details]
Patch

r=me
Comment 3 Joseph Pecoraro 2017-08-29 15:22:55 PDT
Comment on attachment 319287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319287&action=review

> Source/WebInspectorUI/ChangeLog:33
> +        (window.handlePromiseException.window.handlePromiseException):

Heh, you could remove this line it seems wrong.
Comment 4 Nikita Vasilyev 2017-08-29 15:37:35 PDT
Created attachment 319292 [details]
Patch
Comment 5 WebKit Commit Bot 2017-08-29 16:45:22 PDT
Comment on attachment 319292 [details]
Patch

Clearing flags on attachment: 319292

Committed r221324: <http://trac.webkit.org/changeset/221324>
Comment 6 WebKit Commit Bot 2017-08-29 16:45:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-29 16:46:21 PDT
<rdar://problem/34146802>