Bug 176066 – Add support for FetchRequest.body

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Add support for FetchRequest.body

[youenn fablet]

Created attachment 319281 [details]
Patch

[Build Bot]

Attachment 319281 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/fetch/FetchBody.h:99:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 319282 [details]
Patch

[Build Bot]

Attachment 319282 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/fetch/FetchBody.h:99:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 319282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319282&action=review

> LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-disturbed-expected.txt:6
> +FAIL Input request used for creating new request became disturbed assert_equals: body should not change expected object "[object ReadableStream]" but got object "[object ReadableStream]"

I don't understand this failure.

[youenn fablet]

Thanks for the review.

(In reply to Alex Christensen from comment #5)
> Comment on attachment 319282 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319282&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-disturbed-expected.txt:6
> > +FAIL Input request used for creating new request became disturbed assert_equals: body should not change expected object "[object ReadableStream]" but got object "[object ReadableStream]"
> 
> I don't understand this failure.

When using a request A as init to another request B, the expected behavior is to pipe request A stream to request B stream.

Request A stream then gets disturbed but remains the same.

Currently we are not doing so, we are moving the stream to the other request.
I added a FIXME for it in the patch.

[Sam Weinig]

Comment on attachment 319282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319282&action=review

> Source/WebCore/bindings/js/ReadableStream.h:81
> +template<> struct JSConverter<IDLInterface<ReadableStream>> {
> +    static constexpr bool needsState = false;
> +    static constexpr bool needsGlobalObject = false;
> +
> +    static JSC::JSValue convert(ReadableStream* value)
> +    {
> +        if (!value)
> +            return JSC::jsNull();
> +        return value->readableStream();
> +    }
> +};

Can this just be a toJS() implementation?

inline JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, ReadableStream& impl) { return impl.readableStream(); }
inline JSC::JSValue toJS(JSC::ExecState* state, JSDOMGlobalObject* globalObject, ReadableStream* impl) { return impl ? toJS(state, globalObject, *impl) : JSC::jsNull(); }

The top one is often out-of-line.

[WebKit Commit Bot]

Comment on attachment 319282 [details]
Patch

Clearing flags on attachment: 319282

Committed r221329: <http://trac.webkit.org/changeset/221329>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34148373>

[youenn fablet]

(In reply to Sam Weinig from comment #7)
> Comment on attachment 319282 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319282&action=review
> 
> > Source/WebCore/bindings/js/ReadableStream.h:81
> > +template<> struct JSConverter<IDLInterface<ReadableStream>> {
> > +    static constexpr bool needsState = false;
> > +    static constexpr bool needsGlobalObject = false;
> > +
> > +    static JSC::JSValue convert(ReadableStream* value)
> > +    {
> > +        if (!value)
> > +            return JSC::jsNull();
> > +        return value->readableStream();
> > +    }
> > +};
> 
> Can this just be a toJS() implementation?

Right, I'll fix it as a follow-up

[youenn fablet]

Reopening to attach new patch.

[youenn fablet]

Created attachment 319331 [details]
Addendum

[WebKit Commit Bot]

Comment on attachment 319331 [details]
Addendum

Rejecting attachment 319331 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 319331, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4407892

[youenn fablet]

Created attachment 319384 [details]
Addendum

[WebKit Commit Bot]

Comment on attachment 319384 [details]
Addendum

Clearing flags on attachment: 319384

Committed r221395: <http://trac.webkit.org/changeset/221395>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.