Bug 176058 - [Code Style] Use uniform initializer syntax in member initializer list
Summary: [Code Style] Use uniform initializer syntax in member initializer list
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: https://lists.webkit.org/pipermail/we...
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-29 10:52 PDT by Daniel Bates
Modified: 2019-05-15 23:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2017-08-29 10:55 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Daniel Bates 2017-08-29 10:55:05 PDT 
Created attachment 319261 [details]
Patch
Comment 2 Daniel Bates 2017-08-29 10:57:20 PDT 
Comment on attachment 319261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319261&action=review

> Websites/webkit.org/code-style.md:-763
> -    : MySuperClass()

We also prefer to omit calling the default base class constructor (as the compiler will emit code to do this for us). I did not change the example to reflect this. Let me know if I should.
Comment 3 Konstantin Tokarev 2017-08-29 11:19:06 PDT 
Comment on attachment 319261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319261&action=review

>> Websites/webkit.org/code-style.md:-763
>> -    : MySuperClass()
> 
> We also prefer to omit calling the default base class constructor (as the compiler will emit code to do this for us). I did not change the example to reflect this. Let me know if I should.

It may make sense to add arguments to base class ctor to avoid cofusion
Comment 4 Darin Adler 2017-08-29 16:11:12 PDT 
Comment on attachment 319261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319261&action=review

>>> Websites/webkit.org/code-style.md:-763
>>> -    : MySuperClass()
>> 
>> We also prefer to omit calling the default base class constructor (as the compiler will emit code to do this for us). I did not change the example to reflect this. Let me know if I should.
> 
> It may make sense to add arguments to base class ctor to avoid cofusion

I think we should.
Comment 5 Daniel Bates 2019-05-15 23:07:29 PDT 
There appears to be no ❤️ to solidify this in the style guide. Makes me 😢. Maybe one day. Let's just move on.