Bug 176057 – Avoid full style recalcs when computing editability

• Status: NEW
• Component: HTML Editing

[Antti Koivisto]

It shouldn't be needed.

[Antti Koivisto]

Created attachment 319258 [details]
patch

[Build Bot]

Attachment 319258 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Node.cpp:714:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 319260 [details]
patch

[Build Bot]

Attachment 319260 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Node.cpp:714:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 319260 [details]
patch

Attachment 319260 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4404643

New failing tests:
editing/style/apply-style-atomic.html
fast/dom/HTMLElement/dynamic-editability-change.html
editing/selection/user-select-all-selection.html
fast/events/event-input-contentEditable.html
editing/execCommand/justify-right-then-indent-with-problematic-body.html

[Build Bot]

Created attachment 319270 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 319260 [details]
patch

Attachment 319260 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4404668

New failing tests:
fast/events/event-input-contentEditable.html
editing/style/apply-style-atomic.html
fast/dom/HTMLElement/dynamic-editability-change.html
editing/selection/user-select-all-selection.html
editing/execCommand/justify-right-then-indent-with-problematic-body.html
editing/selection/4895428-4.html

[Build Bot]

Created attachment 319271 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 319260 [details]
patch

Attachment 319260 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4404713

New failing tests:
fast/events/event-input-contentEditable.html
editing/style/apply-style-atomic.html
fast/dom/HTMLElement/dynamic-editability-change.html
editing/selection/user-select-all-selection.html
editing/execCommand/justify-right-then-indent-with-problematic-body.html
editing/selection/4895428-4.html

[Build Bot]

Created attachment 319272 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 319260 [details]
patch

Attachment 319260 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4404736

New failing tests:
editing/style/apply-style-atomic.html
fast/dom/HTMLElement/dynamic-editability-change.html
editing/execCommand/justify-right-then-indent-with-problematic-body.html

[Build Bot]

Created attachment 319273 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5