Bug 176056 - [Win] A WTF test is timing out in run-api-tests.
Summary: [Win] A WTF test is timing out in run-api-tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-29 09:49 PDT by Per Arne Vollan
Modified: 2017-08-29 11:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2017-08-29 10:03 PDT, Per Arne Vollan
bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
Patch (1.86 KB, patch)
2017-08-29 11:05 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-08-29 09:49:01 PDT
Tests that timed out:
  WTF_SynchronizedFixedQueue.ProduceOnly
Comment 1 Per Arne Vollan 2017-08-29 10:03:20 PDT
Created attachment 319257 [details]
Patch
Comment 2 Brent Fulgham 2017-08-29 10:49:38 PDT
Comment on attachment 319257 [details]
Patch

I think we should use a conditional here so we don't allow millisecond-accurate platforms to regress.

#if PLATFORM(WIN)
auto sleepAmount = std::chrono::milliseconds(20);
#else
auto sleepAmount = std::chrono::milliseconds(10);
#endif
Comment 3 Per Arne Vollan 2017-08-29 10:58:52 PDT
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 319257 [details]
> Patch
> 
> I think we should use a conditional here so we don't allow
> millisecond-accurate platforms to regress.
> 
> #if PLATFORM(WIN)
> auto sleepAmount = std::chrono::milliseconds(20);
> #else
> auto sleepAmount = std::chrono::milliseconds(10);
> #endif

Thanks for reviewing! I will update the patch before landing.
Comment 4 Per Arne Vollan 2017-08-29 11:05:10 PDT
Created attachment 319262 [details]
Patch
Comment 5 Per Arne Vollan 2017-08-29 11:36:31 PDT
Committed r221307: <https://trac.webkit.org/changeset/221307/webkit>
Comment 6 Radar WebKit Bug Importer 2017-08-29 11:37:22 PDT
<rdar://problem/34137707>