Bug 176052 - REGRESSION(r221064): [GTK] Editor not correctly working after r221064
Summary: REGRESSION(r221064): [GTK] Editor not correctly working after r221064
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2017-08-29 06:43 PDT by Carlos Garcia Campos
Modified: 2017-08-30 00:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.86 KB, patch)
2017-08-29 06:48 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-08-29 06:43:05 PDT
Since r221064 we are not always notified about typing attributes when editor state changes. didChangeSelection no longer includes the typing attributes in EditorStateChange message, it's scheduled to be sent after the compositing layer have been flushed, but that part is not implemented for GTK+ port. This is causing test /webkit2/WebKitWebView/editor-state/typing-attributes to time out.
Comment 1 Carlos Garcia Campos 2017-08-29 06:48:37 PDT
Created attachment 319252 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-08-30 00:00:08 PDT
Committed r221344: <http://trac.webkit.org/changeset/221344>