Bug 176042 – [CMake] Use find_package for libxml2 and libxstl

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Don Olmstead]

Should use find_package for libxml2 and libxslt.

[Don Olmstead]

Created attachment 319224 [details]
Patch

[Konstantin Tokarev]

Comment on attachment 319224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319224&action=review

> Source/WebCore/CMakeLists.txt:137
> +    ${LIBXSLT_INCLUDE_DIR}

Please use alphabetic sorting in such lists wherever possible

[Don Olmstead]

(In reply to Konstantin Tokarev from comment #2)
> Comment on attachment 319224 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319224&action=review
> 
> > Source/WebCore/CMakeLists.txt:137
> > +    ${LIBXSLT_INCLUDE_DIR}
> 
> Please use alphabetic sorting in such lists wherever possible

They're all sorted XML is before XSLT

[Konstantin Tokarev]

Comment on attachment 319224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319224&action=review

>>> Source/WebCore/CMakeLists.txt:137
>>> +    ${LIBXSLT_INCLUDE_DIR}
>> 
>> Please use alphabetic sorting in such lists wherever possible
> 
> They're all sorted XML is before XSLT

I've meant S goes after L

[Don Olmstead]

Created attachment 319265 [details]
Patch

Fixed review comments.

[Don Olmstead]

Comment on attachment 319265 [details]
Patch

Issue with WPE seems to be unrelated to this change.

[WebKit Commit Bot]

Comment on attachment 319265 [details]
Patch

Clearing flags on attachment: 319265

Committed r221309: <http://trac.webkit.org/changeset/221309>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34141433>