Should use find_package for libxml2 and libxslt.
Created attachment 319224 [details] Patch
Comment on attachment 319224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319224&action=review > Source/WebCore/CMakeLists.txt:137 > + ${LIBXSLT_INCLUDE_DIR} Please use alphabetic sorting in such lists wherever possible
(In reply to Konstantin Tokarev from comment #2) > Comment on attachment 319224 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319224&action=review > > > Source/WebCore/CMakeLists.txt:137 > > + ${LIBXSLT_INCLUDE_DIR} > > Please use alphabetic sorting in such lists wherever possible They're all sorted XML is before XSLT
Comment on attachment 319224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319224&action=review >>> Source/WebCore/CMakeLists.txt:137 >>> + ${LIBXSLT_INCLUDE_DIR} >> >> Please use alphabetic sorting in such lists wherever possible > > They're all sorted XML is before XSLT I've meant S goes after L
Created attachment 319265 [details] Patch Fixed review comments.
Comment on attachment 319265 [details] Patch Issue with WPE seems to be unrelated to this change.
Comment on attachment 319265 [details] Patch Clearing flags on attachment: 319265 Committed r221309: <http://trac.webkit.org/changeset/221309>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34141433>