RESOLVED FIXED 176032
[Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions 
https://bugs.webkit.org/show_bug.cgi?id=176032
Summary [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
Andy Estes
Reported 2017-08-28 12:10:19 PDT
[Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
Attachments
Patch (25.98 KB, patch)
2017-08-28 12:19 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (27.93 KB, patch)
2017-08-28 12:44 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (28.40 KB, patch)
2017-08-28 12:53 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (28.92 KB, patch)
2017-08-28 13:35 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (28.48 KB, patch)
2017-08-28 14:40 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-08-28 12:19:52 PDT Comment hidden (obsolete)
Andy Estes
Comment 2 2017-08-28 12:44:19 PDT Comment hidden (obsolete)
Andy Estes
Comment 3 2017-08-28 12:53:42 PDT Comment hidden (obsolete)
Andy Estes
Comment 4 2017-08-28 13:35:43 PDT Comment hidden (obsolete)
Alex Christensen
Comment 5 2017-08-28 13:50:11 PDT
Comment on attachment 319200 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319200&action=review > Source/WebCore/platform/network/mac/CookieJarMac.mm:276 > +static unsigned httpCookieAcceptPolicy(CFHTTPCookieStorageRef cookieStorage) Let's have this return a HTTPCookieAcceptPolicy > Source/WebCore/platform/network/mac/CookieJarMac.mm:279 > + // FIXME: The fallback to NSHTTPCookieStorage should not be present when USE(CFNETWORK) is defined in WebKit. This is an old comment. We renamed this to USE(CFURLCONNECTION), and I'm not sure if that applies.
Andy Estes
Comment 6 2017-08-28 14:40:28 PDT
Created attachment 319209 [details] Patch
WebKit Commit Bot
Comment 7 2017-08-28 15:23:12 PDT
Comment on attachment 319209 [details] Patch Clearing flags on attachment: 319209 Committed r221276: <http://trac.webkit.org/changeset/221276>
WebKit Commit Bot
Comment 8 2017-08-28 15:23:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-08-28 15:23:48 PDT
<rdar://problem/34119907>
Note You need to log in before you can comment on or make changes to this bug.