Bug 176032 - [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
Summary: [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-28 12:10 PDT by Andy Estes
Modified: 2017-08-28 15:23 PDT (History)
8 users (show)

See Also:

Attachments
Patch (25.98 KB, patch)
2017-08-28 12:19 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (27.93 KB, patch)
2017-08-28 12:44 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (28.40 KB, patch)
2017-08-28 12:53 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (28.92 KB, patch)
2017-08-28 13:35 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (28.48 KB, patch)
2017-08-28 14:40 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-08-28 12:10:19 PDT 
[Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
Comment 1 Andy Estes 2017-08-28 12:19:52 PDT Comment hidden (obsolete)
Comment 2 Andy Estes 2017-08-28 12:44:19 PDT Comment hidden (obsolete)
Comment 3 Andy Estes 2017-08-28 12:53:42 PDT Comment hidden (obsolete)
Comment 4 Andy Estes 2017-08-28 13:35:43 PDT Comment hidden (obsolete)
Comment 5 Alex Christensen 2017-08-28 13:50:11 PDT 
Comment on attachment 319200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319200&action=review

> Source/WebCore/platform/network/mac/CookieJarMac.mm:276
> +static unsigned httpCookieAcceptPolicy(CFHTTPCookieStorageRef cookieStorage)

Let's have this return a HTTPCookieAcceptPolicy

> Source/WebCore/platform/network/mac/CookieJarMac.mm:279
> +        // FIXME: The fallback to NSHTTPCookieStorage should not be present when USE(CFNETWORK) is defined in WebKit.

This is an old comment.  We renamed this to USE(CFURLCONNECTION), and I'm not sure if that applies.
Comment 6 Andy Estes 2017-08-28 14:40:28 PDT 
Created attachment 319209 [details]
Patch
Comment 7 WebKit Commit Bot 2017-08-28 15:23:12 PDT 
Comment on attachment 319209 [details]
Patch

Clearing flags on attachment: 319209

Committed r221276: <http://trac.webkit.org/changeset/221276>
Comment 8 WebKit Commit Bot 2017-08-28 15:23:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-08-28 15:23:48 PDT 
<rdar://problem/34119907>