Bug 176031 – [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

FAULTING_IP: 
WebKit!WebFrameLoaderClient::dispatchDecidePolicyForResponse+e1 [c:\cygwin\home\buildbot\slave\win-release\build\source\webkitlegacy\win\webcoresupport\webframeloaderclient.cpp @ 530]
6b660a31 8b01            mov     eax,dword ptr [ecx]

EXCEPTION_RECORD:  ffffffffffffffff -- (.exr 0xffffffffffffffff)
.exr 0xffffffffffffffff
ExceptionAddress: 000000006b660a31 (WebKit!WTF::Function<void __cdecl(enum WebCore::PolicyAction)>::operator()+0x0000000000000007)
   ExceptionCode: c0000005 (Access violation)
  ExceptionFlags: 00000000
NumberParameters: 2
   Parameter[0]: 0000000000000000
   Parameter[1]: 0000000000000000
Attempt to read from address 0000000000000000

STACK_TEXT:  
001ce5e4 6b725b0b 0912e7e0 0912e718 001ce654 WebKit!WebFrameLoaderClient::dispatchDecidePolicyForResponse+0xe1
001ce5fc 6b71d605 0912e7e0 001ce654 091b1b70 WebKit!WebCore::FrameLoader::checkContentPolicy+0x2b
001ce6ec 6b71d12b 091b1b70 001ce72c 6bca713a WebKit!WebCore::DocumentLoader::responseReceived+0x435
001ce6f8 6bca713a 091b19f8 091b1b70 71ce6ed0 WebKit!WebCore::DocumentLoader::responseReceived+0xb
001ce72c 6b7336ec 001ceacc 05e0c4a0 091ae290 WebKit!WebCore::CachedRawResource::responseReceived+0x6a
001ceaa4 6b72ebf6 001ceacc 05e0c4a0 001cecf8 WebKit!WebCore::SubresourceLoader::didReceiveResponse+0x30c
001ceab4 6bcb4b8a 091ae870 001ceacc 05de4c60 WebKit!WebCore::ResourceLoader::didReceiveResponse+0x26
001cecf8 6bcb4441 05dcb458 05e0c4a0 001ced2c WebKit!WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse+0x9a
001ced08 7150c7d4 05dcb458 05e0c4a0 091ae8b8 WebKit!WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveResponseCallback+0x11
WARNING: Stack unwind information not available. Following frames may be wrong.
001ced2c 7150b382 05e0c4a0 001ced58 d1a9a868 CFNetwork!CFHTTPCookieCreateWithResponseHeaderFields+0xb804
001ceeac 7150b4b7 001ceee4 00000003 d1a9abe8 CFNetwork!CFHTTPCookieCreateWithResponseHeaderFields+0xa3b2
001cf014 7150a470 05df5d54 00000003 05de8950 CFNetwork!CFHTTPCookieCreateWithResponseHeaderFields+0xa4e7
001cf038 713c15e2 d1a9b5d8 057824f0 00000000 CFNetwork!CFHTTPCookieCreateWithResponseHeaderFields+0x94a0
001cf0f0 713c10ec 057824fc 001cf128 71621268 CFNetwork+0x115e2
001cf0fc 71621268 05de8950 00662c28 00662c28 CFNetwork+0x110ec
001cf128 716248f5 00662c28 00000001 00662c80 CoreFoundation!CFDateFormatterGetTimeStyle+0x6e03f
001cf18c 71624e11 00662c80 00000000 00000000 CoreFoundation!CFDateFormatterGetTimeStyle+0x716cc
001cf1e0 71624f60 00662c28 7171cfa0 00000000 CoreFoundation!CFDateFormatterGetTimeStyle+0x71be8
001cf328 71d79a7a 001cf340 001e6df0 00552300 CoreFoundation!CFDateFormatterGetTimeStyle+0x71d37
001cfba0 71d79c4e 00000002 00552300 001cfe78 DumpRenderTreeLib!main+0x43a
001cfbb0 001d16c9 00000002 00552300 001e6dec DumpRenderTreeLib!dllLauncherEntryPoint+0xe
001cfe78 001d32ba 00000002 00552300 00555b10 DumpRenderTree!main+0x469
001cfec4 7699336a 7efde000 001cff10 77d79902 DumpRenderTree!__scrt_common_main_seh+0xff
001cfed0 77d79902 7efde000 30e64911 00000000 KERNEL32!BaseThreadInitThunk+0x12
001cff10 77d798d5 001d3337 7efde000 00000000 ntdll_77d40000!RtlInitializeExceptionChain+0x63
001cff28 00000000 001d3337 7efde000 00000000 ntdll_77d40000!RtlInitializeExceptionChain+0x36

[Per Arne Vollan]

Created attachment 319189 [details]
Patch

[Brent Fulgham]

Comment on attachment 319189 [details]
Patch

r=me. Consider omitting the comments, which I don't think are really necessary. The ChangeLog explains things well, and the code isn't very confusing.

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #2)
> Comment on attachment 319189 [details]
> Patch
> 
> r=me. Consider omitting the comments, which I don't think are really
> necessary. The ChangeLog explains things well, and the code isn't very
> confusing.

Thanks for reviewing! I will remove the comments before landing.

[Per Arne Vollan]

Committed r221268: <https://trac.webkit.org/changeset/221268/webkit>

[Radar WebKit Bug Importer]

<rdar://problem/34116974>