Bug 176030 – Layout test http/tests/websocket/tests/hybi/send-object-tostring-check.html is flaky

• Status: REOPENED
• Component: New Bugs

[Matt Lewis]

http/tests/websocket/tests/hybi/send-object-tostring-check.html is a flaky failure on multiple WK2 platforms according to the flakiness dashboard. More specifically it shows the test is flaky on iOS WK2 and El Capitan WK2 Debug. The test failed once on Sierra WK2 Release.

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fsend-object-tostring-check.html

current build:
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r221258%20(2749)/results.html

Diff:
--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/http/tests/websocket/tests/hybi/send-object-tostring-check-actual.txt
@@ -1,9 +1,11 @@
+CONSOLE MESSAGE: WebSocket network error: The operation couldn’t be completed. Connection reset by peer
+CONSOLE MESSAGE: WebSocket network error: The operation couldn’t be completed. Connection reset by peer
 WebSocket: Object's toString method should be called only once.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 PASS testObj.callCounter is 1
-PASS closeEvent.wasClean is true
+FAIL closeEvent.wasClean should be true. Was false.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Russell Epstein]

This is still happening as of 246561 with the same diff on Mac Debug WK2 and iOS WK2.

History: 

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fsend-object-tostring-check.html



Diff:

@@ -1,9 +1,11 @@
+CONSOLE MESSAGE: WebSocket network error: The operation couldn’t be completed. Connection reset by peer
+CONSOLE MESSAGE: WebSocket network error: The operation couldn’t be completed. Connection reset by peer
 WebSocket: Object's toString method should be called only once.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 PASS testObj.callCounter is 1
-PASS closeEvent.wasClean is true
+FAIL closeEvent.wasClean should be true. Was false.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Russell Epstein]

Created attachment 372388 [details]
Patch

[Russell Epstein]

Created attachment 372389 [details]
Patch

[Russell Epstein]

Created attachment 372390 [details]
Update Test Expectations

[WebKit Commit Bot]

Comment on attachment 372390 [details]
Update Test Expectations

Clearing flags on attachment: 372390

Committed r246574: <https://trac.webkit.org/changeset/246574>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/51869153>

[Russell Epstein]

Marked test as flakey in https://trac.webkit.org/changeset/246574/webkit

[Truitt Savell]

Reopening for investigation.

The test marked pass/fail on iOS here is now flaky timing out. Updated expectations https://trac.webkit.org/changeset/285040/webkit