Bug 176027 - [WinCairo] Add PlatformWin cmake for Webkit
Summary: [WinCairo] Add PlatformWin cmake for Webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-28 10:52 PDT by Stephan Szabo
Modified: 2017-08-28 16:31 PDT (History)
7 users (show)

See Also:


Attachments
PlatformWin cmake file for Webkit (3.39 KB, patch)
2017-08-28 10:52 PDT, Stephan Szabo
bfulgham: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
PlatformWin cmake file for Webkit with Changelog (3.92 KB, patch)
2017-08-28 14:00 PDT, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2017-08-28 10:52:20 PDT
Created attachment 319182 [details]
PlatformWin cmake file for Webkit

We (Sony) are going to be putting up files for getting WinCairo going with non-legacy Webkit. It's a bunch of files, so we're breaking it up into a series of smaller changes. Any input on what seems like the best sizing for changes for review purposes would also be appreciated.

To start with, the base cmake file for PlatformWin for later patches to add onto.
Comment 1 Brent Fulgham 2017-08-28 12:43:02 PDT
Comment on attachment 319182 [details]
PlatformWin cmake file for Webkit

Modern webkit, here comes Windows! r=me.
Comment 2 WebKit Commit Bot 2017-08-28 13:45:18 PDT
Comment on attachment 319182 [details]
PlatformWin cmake file for Webkit

Rejecting attachment 319182 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 319182, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
176027.
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/4399034
Comment 3 Stephan Szabo 2017-08-28 14:00:07 PDT
Created attachment 319206 [details]
PlatformWin cmake file for Webkit with Changelog
Comment 4 WebKit Commit Bot 2017-08-28 16:29:32 PDT
Comment on attachment 319206 [details]
PlatformWin cmake file for Webkit with Changelog

Clearing flags on attachment: 319206

Committed r221279: <http://trac.webkit.org/changeset/221279>
Comment 5 WebKit Commit Bot 2017-08-28 16:29:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-08-28 16:31:35 PDT
<rdar://problem/34121437>