Bug 176024 – [GTK] Layout test fast/forms/file/webkitdirectory-open-panel.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Layout test fast/forms/file/webkitdirectory-open-panel.html is failing since it was added in r221177. I'm not sure if this is an actual problem, or if it's OK that the results are unordered. I'll mark it as expected fail for now and if Chris thinks it's OK, we can add a platform expectation instead.

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/forms/file/webkitdirectory-open-panel-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/forms/file/webkitdirectory-open-panel-actual.txt
@@ -7,17 +7,18 @@
 
 PASS inputElement.webkitdirectory is true
 PASS fileList.length is 5
-PASS fileList[0].name is "file1.txt"
-PASS fileList[0].webkitRelativePath is "testFiles/file1.txt"
-PASS fileList[1].name is "file2.txt"
-PASS fileList[1].webkitRelativePath is "testFiles/file2.txt"
-PASS fileList[2].name is "file3.txt"
-PASS fileList[2].webkitRelativePath is "testFiles/subfolder1/file3.txt"
-PASS fileList[3].name is "file4.txt"
-PASS fileList[3].webkitRelativePath is "testFiles/subfolder2/file4.txt"
-PASS fileList[4].name is "file5.txt"
-PASS fileList[4].webkitRelativePath is "testFiles/subfolder2/subfolder2a/file5.txt"
+FAIL fileList[0].name should be file1.txt. Was file2.txt.
+FAIL fileList[0].webkitRelativePath should be testFiles/file1.txt. Was testFiles/file2.txt.
+FAIL fileList[1].name should be file2.txt. Was file1.txt.
+FAIL fileList[1].webkitRelativePath should be testFiles/file2.txt. Was testFiles/file1.txt.
+FAIL fileList[2].name should be file3.txt. Was file4.txt.
+FAIL fileList[2].webkitRelativePath should be testFiles/subfolder1/file3.txt. Was testFiles/subfolder2/file4.txt.
+FAIL fileList[3].name should be file4.txt. Was file5.txt.
+FAIL fileList[3].webkitRelativePath should be testFiles/subfolder2/file4.txt. Was testFiles/subfolder2/subfolder2a/file5.txt.
+FAIL fileList[4].name should be file5.txt. Was file3.txt.
+FAIL fileList[4].webkitRelativePath should be testFiles/subfolder2/subfolder2a/file5.txt. Was testFiles/subfolder1/file3.txt.
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE

[Chris Dumez]

If it is WebKit1, you probably need to enable the feature in your DRT.

[Chris Dumez]

My comment was about the failures. The fact that the lines are in a different order may mean that listDirectory() works differently on Mac and Linux and returns non-sorted results. We may want to make the test deal with non-sorted results.

[Michael Catanzaro]

(In reply to Chris Dumez from comment #1)
> If it is WebKit1, you probably need to enable the feature in your DRT.

WebKit1 is long gone! I think the lines being unsorted is the only failure.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 336184 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 336184 [details]
Patch

Clearing flags on attachment: 336184

Committed r229802: <https://trac.webkit.org/changeset/229802>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.