RESOLVED FIXED 176014
[PAL] Fix "None" suffix in PAL
https://bugs.webkit.org/show_bug.cgi?id=176014
Summary [PAL] Fix "None" suffix in PAL
Yoshiaki Jitsukawa
Reported 2017-08-28 00:10:52 PDT
I'm trying to rename *None.cpp to *.cpp, based on the suggestion given in "[webkit-dev] None Suffix in PAL": > I'd suggest not having any suffix when it's empty stub and suffix it with Generic when it's a generic implementation some platforms in the accordance with the existing convention.
Attachments
Patch (9.14 KB, patch)
2017-08-28 00:19 PDT, Yoshiaki Jitsukawa
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan (1.46 MB, application/zip)
2017-08-28 01:26 PDT, Build Bot
no flags
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.55 MB, application/zip)
2017-08-28 01:30 PDT, Build Bot
no flags
Archive of layout-test-results from ews112 for mac-elcapitan (2.26 MB, application/zip)
2017-08-28 02:02 PDT, Build Bot
no flags
Patch (9.35 KB, patch)
2017-08-28 04:36 PDT, Yoshiaki Jitsukawa
no flags
Patch (8.81 KB, patch)
2017-08-30 14:38 PDT, Yoshiaki Jitsukawa
no flags
Yoshiaki Jitsukawa
Comment 1 2017-08-28 00:19:43 PDT
Created attachment 319165 [details] Patch This patch renames KillRingNone.cpp to KillRing.cpp and SoundNone.cpp to Sound.cpp and also fixes relevant Xcode and Cmake files.
Build Bot
Comment 2 2017-08-28 01:26:26 PDT
Comment on attachment 319165 [details] Patch Attachment 319165 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4395878 New failing tests: editing/pasteboard/emacs-killring-alternating-append-prepend.html editing/pasteboard/emacs-ctrl-a-k-y.html editing/pasteboard/emacs-ctrl-k-y-001.html editing/pasteboard/emacs-ctrl-k-with-move.html editing/pasteboard/emacs-killring-backward-delete-prepend.html
Build Bot
Comment 3 2017-08-28 01:26:27 PDT
Created attachment 319167 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 4 2017-08-28 01:30:36 PDT
Comment on attachment 319165 [details] Patch Attachment 319165 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4395881 New failing tests: editing/pasteboard/emacs-killring-alternating-append-prepend.html editing/pasteboard/emacs-ctrl-a-k-y.html editing/pasteboard/emacs-killring-backward-delete-prepend.html editing/pasteboard/emacs-ctrl-k-with-move.html
Build Bot
Comment 5 2017-08-28 01:30:38 PDT
Created attachment 319168 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 6 2017-08-28 02:02:23 PDT
Comment on attachment 319165 [details] Patch Attachment 319165 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4395918 New failing tests: editing/pasteboard/emacs-killring-alternating-append-prepend.html editing/pasteboard/emacs-ctrl-a-k-y.html editing/pasteboard/emacs-ctrl-k-y-001.html editing/pasteboard/emacs-ctrl-k-with-move.html editing/pasteboard/emacs-killring-backward-delete-prepend.html
Build Bot
Comment 7 2017-08-28 02:02:25 PDT
Created attachment 319171 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Yoshiaki Jitsukawa
Comment 8 2017-08-28 04:36:19 PDT
Yoshiaki Jitsukawa
Comment 9 2017-08-30 14:38:26 PDT
Myles C. Maxfield
Comment 10 2017-08-30 15:25:06 PDT
Did you mean to mark this patch as "r?"?
Yoshiaki Jitsukawa
Comment 11 2017-08-30 15:39:52 PDT
(In reply to Myles C. Maxfield from comment #10) > Did you mean to mark this patch as "r?"? Ah, yes. Thank you!
WebKit Commit Bot
Comment 12 2017-08-30 16:03:55 PDT
Comment on attachment 319405 [details] Patch Clearing flags on attachment: 319405 Committed r221405: <http://trac.webkit.org/changeset/221405>
WebKit Commit Bot
Comment 13 2017-08-30 16:03:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2017-08-30 16:05:14 PDT
Note You need to log in before you can comment on or make changes to this bug.