Bug 176011 – [iOS WK2] Web process crashes after changing selection to the end of the document when speaking a selection

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Wenson Hsieh]

<rdar://problem/32614095>

[Wenson Hsieh]

Created attachment 319156 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 319156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319156&action=review

> Source/WebCore/editing/Editing.cpp:1095
> +VisiblePosition visiblePositionForPositionWithOffset(const VisiblePosition& position, int32_t offset)

We should make this function take unsigned instead of int32_t. It's non-sensical to have a negative offset.

[Wenson Hsieh]

Comment on attachment 319156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319156&action=review

>> Source/WebCore/editing/Editing.cpp:1095
>> +VisiblePosition visiblePositionForPositionWithOffset(const VisiblePosition& position, int32_t offset)
> 
> We should make this function take unsigned instead of int32_t. It's non-sensical to have a negative offset.

Sounds good! Changed to unsigned.

[Wenson Hsieh]

Comment on attachment 319156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319156&action=review

>>> Source/WebCore/editing/Editing.cpp:1095
>>> +VisiblePosition visiblePositionForPositionWithOffset(const VisiblePosition& position, int32_t offset)
>> 
>> We should make this function take unsigned instead of int32_t. It's non-sensical to have a negative offset.
> 
> Sounds good! Changed to unsigned.

Actually, a call site of visiblePositionForPositionWithOffset in AXObjectCache.cpp takes in a negative integer -- we'll change this to be an int instead.

[Wenson Hsieh]

Created attachment 319163 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 319163 [details]
Patch for landing

Clearing flags on attachment: 319163

Committed r221233: <http://trac.webkit.org/changeset/221233>