Add WKUIDelegatePrivate equivalent of WKPageUIClient's saveDataToFileInDownloadsFolder
Created attachment 319109 [details] Patch
Comment on attachment 319109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319109&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:6126 > + saveDataToFileInDownloadsFolder(WTFMove(suggestedFilename), "application/pdf", WTFMove(originatingURL), Can you use ASCIILiteral() for "application/pdf"? > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:178 > + EXPECT_EQ(webView, saveDataToFileArguments.webView); > + EXPECT_TRUE([saveDataToFileArguments.data isEqualToData:[NSData dataWithContentsOfURL:pdfURL]]); > + EXPECT_STREQ([saveDataToFileArguments.suggestedFilename UTF8String], "test.pdf"); > + EXPECT_STREQ([saveDataToFileArguments.mimeType UTF8String], "application/pdf"); > + EXPECT_STREQ([[saveDataToFileArguments.url absoluteString] UTF8String], [[pdfURL absoluteString] UTF8String]); This is fine, but you could just move these EXPECTs into -_webView:saveDataToFile:suggestedFilename:mimeType:originatingURL: and avoid creating a struct.
Created attachment 319113 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
http://trac.webkit.org/r221216
<rdar://problem/34092924>