Now that there is a script which will download a GitHub release package it should be used instead of the original perl script.
Created attachment 319053 [details] Patch This uses download-latest-github-release.py to get the latest WinCairoRequirements.
Attachment 319053 [details] did not pass style-queue: ERROR: Tools/Scripts/download-latest-github-release.py:48: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/Scripts/download-latest-github-release.py:106: [main] Undefined variable 'ERROR' [pylint/E0602] [5] ERROR: Tools/Scripts/download-latest-github-release.py:129: Undefined variable 'ERROR' [pylint/E0602] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319058 [details] Patch Fix style
Attachment 319058 [details] did not pass style-queue: ERROR: Tools/Scripts/download-latest-github-release.py:44: expected 2 blank lines, found 1 [pep8/E302] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 319060 [details] Patch Fix logic error
Comment on attachment 319060 [details] Patch Modified download-latest-github-release.py so it can be imported and used from the script directly. This means the update-webkit-wincairo-libs doesn't have to keep track of whether the file was updated. Also Removed the old perl implementation.
This should fix the WinCairo builds as the referenced repository has the sqlite files staged so CMake will pick them up.
Comment on attachment 319060 [details] Patch Nice! r=me.
Comment on attachment 319060 [details] Patch Clearing flags on attachment: 319060 Committed r221191: <http://trac.webkit.org/changeset/221191>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34083805>