Bug 175951 - Web Inspector: Views should explicitly remove event listeners from managers/Frame
Summary: Web Inspector: Views should explicitly remove event listeners from managers/F...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-24 12:55 PDT by Ross Kirsling
Modified: 2017-10-10 12:25 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.31 KB, patch)
2017-08-24 13:39 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (8.53 KB, patch)
2017-10-10 11:43 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2017-08-24 12:55:41 PDT 
(Based on an IRC conversation with JoePeck.)

Although some views have a single persistent instance, ideally any event listeners attached to managers and the like should still be cleaned up in closed().
Comment 1 Ross Kirsling 2017-08-24 13:39:47 PDT 
Created attachment 319015 [details]
Patch
Comment 2 BJ Burg 2017-10-09 11:32:06 PDT 
Comment on attachment 319015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319015&action=review

r=me. Please rebase and upload a new patch to EWS before landing.

> Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:106
> +

Technically outside the scope of this patch, but this should also unregister from WI.consoleDrawer and WI.TabBrowser.
Comment 3 Ross Kirsling 2017-10-10 11:43:01 PDT 
Created attachment 323327 [details]
Patch
Comment 4 WebKit Commit Bot 2017-10-10 12:24:07 PDT 
Comment on attachment 323327 [details]
Patch

Clearing flags on attachment: 323327

Committed r223137: <http://trac.webkit.org/changeset/223137>
Comment 5 WebKit Commit Bot 2017-10-10 12:24:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-10 12:25:31 PDT 
<rdar://problem/34916512>