RESOLVED FIXED 175943
Web Inspector: Table grid shouldn't show behind empty state 
https://bugs.webkit.org/show_bug.cgi?id=175943
Summary Web Inspector: Table grid shouldn't show behind empty state
Alan Sien Wei Hshieh
Reported 2017-08-24 11:45:24 PDT
Created attachment 318999 [details] Screenshot of the empty state Currently, when a table is showing an empty state, such as "No Recording Data", grid lines show behind the empty state. This doesn't make sense because the table has no contents. As a result, the grid is just making the empty state less legible. We should show the usual white background behind the empty state so that the "No Recording Data", or similar, empty state is more legible. Steps to reproduce: 1. Go to Recordings with no recording data 2. Look in the recording data (left) sidebar Results: There are alternating row grid lines behind the empty state label. The background should just be a solid color.
Attachments
Screenshot of the empty state (69.79 KB, image/png)
2017-08-24 11:45 PDT, Alan Sien Wei Hshieh 		no flags
Details
Patch (1.59 KB, patch)
2017-08-24 12:39 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (264.75 KB, image/png)
2017-08-24 12:39 PDT, Devin Rousso 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-08-24 12:39:36 PDT
Created attachment 319009 [details] Patch
Devin Rousso
Comment 2 2017-08-24 12:39:52 PDT
Created attachment 319010 [details] [Image] After Patch is applied
Blaze Burg
Comment 3 2017-08-24 12:44:55 PDT
Comment on attachment 319009 [details] Patch r=me
WebKit Commit Bot
Comment 4 2017-08-24 13:18:18 PDT
Comment on attachment 319009 [details] Patch Clearing flags on attachment: 319009 Committed r221157: <http://trac.webkit.org/changeset/221157>
WebKit Commit Bot
Comment 5 2017-08-24 13:18:20 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-08-24 13:19:01 PDT
<rdar://problem/34065426>
Note You need to log in before you can comment on or make changes to this bug.