Bug 175922 – [iOS] ViewServices started by StoreKitUIService may get suspended unexpectedly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

ViewServices started by StoreKitUIService may get suspended unexpectedly.

[Chris Dumez]

<rdar://problem/34028921>

[Chris Dumez]

Created attachment 318962 [details]
Patch

[Tim Horton]

Comment on attachment 318962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318962&action=review

> Source/WebKit/UIProcess/ApplicationStateTracker.mm:153
> +            m_isInBackground = false;

Can’t they just use the WKWebViewConfiguration SPI to be treated like they’re always in the foreground, like every other instance of this?

[Tim Horton]

Comment on attachment 318962 [details]
Patch

If not, please kick back for review, but it seems wrong to special case this when we already have a mechanism to handle it. If this were a generic mechanism to handle doubly-service-hosted web views, that would be a different story.

[Tim Horton]

Specifically, I am referring to _setAlwaysRunsAtForegroundPriority:

[Yongjun Zhang]

(In reply to Tim Horton from comment #5)
> Specifically, I am referring to _setAlwaysRunsAtForegroundPriority:

The host app doesn’t have access to WKWebview since it is using Safari view controller.

[WebKit Commit Bot]

Comment on attachment 318962 [details]
Patch

Clearing flags on attachment: 318962

Committed r221138: <http://trac.webkit.org/changeset/221138>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.