Bug 175907 – Stop using PolicyCallback for new window policies

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Stop using PolicyCallback for new window policies

[Alex Christensen]

Created attachment 318922 [details]
Patch

[Alex Christensen]

I made the NavigationAction copy more explicit.
http://trac.webkit.org/r221109

[Ryan Haddad]

(In reply to Alex Christensen from comment #2)
> I made the NavigationAction copy more explicit.
> http://trac.webkit.org/r221109
This change introduced assertion failures on iOS and macOS:
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r221109%20(2679)/results.html
https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r221109%20(3496)/results.html

[Radar WebKit Bug Importer]

<rdar://problem/34048194>

[Ryan Haddad]

(In reply to Ryan Haddad from comment #3)
> (In reply to Alex Christensen from comment #2)
> > I made the NavigationAction copy more explicit.
> > http://trac.webkit.org/r221109
> This change introduced assertion failures on iOS and macOS:
> https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/
> r221109%20(2679)/results.html
> https://build.webkit.org/results/
> Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r221109%20(3496)/
> results.html

SHOULD NEVER BE REACHED
/Volumes/Data/slave/sierra-debug/build/Source/WebCore/loader/PolicyChecker.cpp(177) : auto WebCore::PolicyChecker::checkNewWindowPolicy(WebCore::NavigationAction &&, const WebCore::ResourceRequest &, WebCore::FormState *, const WTF::String &, NewWindowPolicyDecisionFunction)::(anonymous class)::operator()(WebCore::PolicyAction) const

[Ryan Haddad]

Reverted r221109 for reason:

This change caused assertion failures on iOS and macOS debug bots.

Committed r221122: <http://trac.webkit.org/changeset/221122>

[Alex Christensen]

Comment on attachment 318922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318922&action=review

> Source/WebCore/loader/PolicyChecker.cpp:171
> +            break;

Oops, these need to be returns.

[Alex Christensen]

Created attachment 318998 [details]
patch

[WebKit Commit Bot]

Comment on attachment 318998 [details]
patch

Clearing flags on attachment: 318998

Committed r221162: <http://trac.webkit.org/changeset/221162>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.