WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
175902
[Cache API] Unify WebCore and WebKit error handling
https://bugs.webkit.org/show_bug.cgi?id=175902
Summary
[Cache API] Unify WebCore and WebKit error handling
youenn fablet
Reported
2017-08-23 13:20:47 PDT
We should use more expected and have a single error enumeration.
Attachments
Patch
(77.52 KB, patch)
2017-08-23 13:35 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch
(89.08 KB, patch)
2017-08-23 14:15 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch
(89.66 KB, patch)
2017-08-23 14:30 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch - windows fix
(1.35 KB, patch)
2017-08-23 17:07 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2017-08-23 13:35:45 PDT
Created
attachment 318911
[details]
Patch
youenn fablet
Comment 2
2017-08-23 14:15:27 PDT
Created
attachment 318917
[details]
Patch
Build Bot
Comment 3
2017-08-23 14:18:18 PDT
Attachment 318917
[details]
did not pass style-queue: ERROR: Source/WebCore/Modules/cache/DOMCache.h:48: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 4
2017-08-23 14:30:18 PDT
Created
attachment 318919
[details]
Patch
Build Bot
Comment 5
2017-08-23 14:32:43 PDT
Attachment 318919
[details]
did not pass style-queue: ERROR: Source/WebCore/Modules/cache/DOMCache.h:48: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 6
2017-08-23 15:33:19 PDT
Comment on
attachment 318919
[details]
Patch Clearing flags on attachment: 318919 Committed
r221112
: <
http://trac.webkit.org/changeset/221112
>
WebKit Commit Bot
Comment 7
2017-08-23 15:33:21 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2017-08-23 15:34:19 PDT
<
rdar://problem/34045933
>
Ryan Haddad
Comment 9
2017-08-23 16:08:52 PDT
(In reply to WebKit Commit Bot from
comment #6
)
> Comment on
attachment 318919
[details]
> Patch > > Clearing flags on attachment: 318919 > > Committed
r221112
: <
http://trac.webkit.org/changeset/221112
>
This change broke the Windows build:
https://build.webkit.org/builders/Apple%20Win%20Release%20(Build)/builds/3884
youenn fablet
Comment 10
2017-08-23 17:07:41 PDT
Reopening to attach new patch.
youenn fablet
Comment 11
2017-08-23 17:07:42 PDT
Created
attachment 318942
[details]
Patch - windows fix
WebKit Commit Bot
Comment 12
2017-08-23 17:39:27 PDT
Comment on
attachment 318942
[details]
Patch - windows fix Clearing flags on attachment: 318942 Committed
r221123
: <
http://trac.webkit.org/changeset/221123
>
WebKit Commit Bot
Comment 13
2017-08-23 17:39:28 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug