Bug 175899 - ASSERTION FAILED: !m_valueOrException under FontFaceSet::completedLoading loading a Serious Eats page
Summary: ASSERTION FAILED: !m_valueOrException under FontFaceSet::completedLoading loa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-23 12:35 PDT by Tim Horton
Modified: 2017-09-27 12:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.06 KB, patch)
2017-09-12 16:37 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-08-23 12:35:08 PDT 
Steps to Reproduce:

1. Load http://www.seriouseats.com/recipes/2017/08/roasted-carrots-black-sesame-dressing-recipe.html in a ToT debug build.

Expected: Carrots.
Actual: Crash. For me, every time. I have r221082.

ASSERTION FAILED: !m_valueOrException
/Users/thorton/src/WebKit/OpenSource/Source/WebCore/bindings/js/DOMPromiseProxy.h(291) : void WebCore::DOMPromiseProxyWithResolveCallback<WebCore::IDLInterface<WebCore::FontFaceSet> >::resolve(typename IDLType::ParameterType) [IDLType = WebCore::IDLInterface<WebCore::FontFaceSet>]
1   0x195c0a9ad WTFCrash
2   0x188aab579 WebCore::DOMPromiseProxyWithResolveCallback<WebCore::IDLInterface<WebCore::FontFaceSet> >::resolve(WebCore::FontFaceSet&)
3   0x188aac779 WebCore::FontFaceSet::completedLoading()
4   0x18856f1b0 WebCore::CSSFontFaceSet::decrementActiveCount()
5   0x188574363 WebCore::CSSFontFaceSet::fontStateChanged(WebCore::CSSFontFace&, WebCore::CSSFontFace::Status, WebCore::CSSFontFace::Status)
6   0x18856d5c7 WebCore::CSSFontFace::setStatus(WebCore::CSSFontFace::Status)::$_14::operator()(WebCore::CSSFontFace::Client&) const
Comment 1 Myles C. Maxfield 2017-09-12 14:50:15 PDT 

*** This bug has been marked as a duplicate of bug 176525 ***
Comment 2 Myles C. Maxfield 2017-09-12 16:11:59 PDT 
Turns out this isn't a duplicate.
Comment 3 Myles C. Maxfield 2017-09-12 16:32:19 PDT 
Upon closer investigation, 176525 fixed it but I'd still like to add a test and update the patch with a slight style change.
Comment 4 Myles C. Maxfield 2017-09-12 16:37:12 PDT 
Created attachment 320581 [details]
Patch
Comment 5 WebKit Commit Bot 2017-09-12 17:13:05 PDT 
Comment on attachment 320581 [details]
Patch

Clearing flags on attachment: 320581

Committed r221948: <http://trac.webkit.org/changeset/221948>
Comment 6 WebKit Commit Bot 2017-09-12 17:13:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:47:47 PDT 
<rdar://problem/34694033>