Bug 175898 - _WKThumbnailView snapshots have to be copied by CA on first commit due to bad row alignment
Summary: _WKThumbnailView snapshots have to be copied by CA on first commit due to bad...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-23 12:23 PDT by Tim Horton
Modified: 2017-08-24 11:11 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.04 KB, patch)
2017-08-23 12:30 PDT, Tim Horton 		sam: review+
Details | Formatted Diff | Diff
patch (9.70 KB, patch)
2017-08-23 17:16 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (10.01 KB, patch)
2017-08-23 17:20 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (9.69 KB, patch)
2017-08-23 17:27 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-08-23 12:23:52 PDT 
_WKThumbnailView snapshots have to be copied by CA on first commit due to bad row alignment
Comment 1 Tim Horton 2017-08-23 12:30:02 PDT 
Created attachment 318900 [details]
Patch
Comment 2 Tim Horton 2017-08-23 12:30:20 PDT 
I'm not sure that IOSurface alignment method is the best way, I'm asking around.
Comment 3 Sam Weinig 2017-08-23 16:12:04 PDT 
Comment on attachment 318900 [details]
Patch

Looks good. Fix the other builds.
Comment 4 Tim Horton 2017-08-23 17:16:00 PDT 
Created attachment 318943 [details]
patch
Comment 5 Tim Horton 2017-08-23 17:20:31 PDT 
Created attachment 318944 [details]
Patch
Comment 6 Tim Horton 2017-08-23 17:27:30 PDT 
Created attachment 318948 [details]
Patch
Comment 7 Tim Horton 2017-08-23 17:43:49 PDT 
<rdar://problem/34029673>
Comment 8 Simon Fraser (smfr) 2017-08-24 08:42:09 PDT 
Comment on attachment 318948 [details]
Patch

I assume this means that ShareableBitmap can how have a few junk bytes at the end of each row? Are all clients prepared for this?
Comment 9 Tim Horton 2017-08-24 09:07:20 PDT 
(In reply to Simon Fraser (smfr) from comment #8)
> Comment on attachment 318948 [details]
> Patch
> 
> I assume this means that ShareableBitmap can how have a few junk bytes at
> the end of each row? Are all clients prepared for this?

Hopefully! I’m not sure there are any clients that don’t just use CGImage, which just handles this under the covers
Comment 10 Tim Horton 2017-08-24 10:42:02 PDT 
(In reply to Tim Horton from comment #9)
> (In reply to Simon Fraser (smfr) from comment #8)
> > Comment on attachment 318948 [details]
> > Patch
> > 
> > I assume this means that ShareableBitmap can how have a few junk bytes at
> > the end of each row? Are all clients prepared for this?
> 
> Hopefully! I’m not sure there are any clients that don’t just use CGImage,
> which just handles this under the covers

There should be none, we don't even expose the raw data.
Comment 11 WebKit Commit Bot 2017-08-24 11:11:19 PDT 
Comment on attachment 318948 [details]
Patch

Clearing flags on attachment: 318948

Committed r221149: <http://trac.webkit.org/changeset/221149>
Comment 12 WebKit Commit Bot 2017-08-24 11:11:21 PDT 
All reviewed patches have been landed.  Closing bug.