Bug 175898 – _WKThumbnailView snapshots have to be copied by CA on first commit due to bad row alignment

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

_WKThumbnailView snapshots have to be copied by CA on first commit due to bad row alignment

[Tim Horton]

Created attachment 318900 [details]
Patch

[Tim Horton]

I'm not sure that IOSurface alignment method is the best way, I'm asking around.

[Sam Weinig]

Comment on attachment 318900 [details]
Patch

Looks good. Fix the other builds.

[Tim Horton]

Created attachment 318943 [details]
patch

[Tim Horton]

Created attachment 318944 [details]
Patch

[Tim Horton]

Created attachment 318948 [details]
Patch

[Tim Horton]

<rdar://problem/34029673>

[Simon Fraser (smfr)]

Comment on attachment 318948 [details]
Patch

I assume this means that ShareableBitmap can how have a few junk bytes at the end of each row? Are all clients prepared for this?

[Tim Horton]

(In reply to Simon Fraser (smfr) from comment #8)
> Comment on attachment 318948 [details]
> Patch
> 
> I assume this means that ShareableBitmap can how have a few junk bytes at
> the end of each row? Are all clients prepared for this?

Hopefully! I’m not sure there are any clients that don’t just use CGImage, which just handles this under the covers

[Tim Horton]

(In reply to Tim Horton from comment #9)
> (In reply to Simon Fraser (smfr) from comment #8)
> > Comment on attachment 318948 [details]
> > Patch
> > 
> > I assume this means that ShareableBitmap can how have a few junk bytes at
> > the end of each row? Are all clients prepared for this?
> 
> Hopefully! I’m not sure there are any clients that don’t just use CGImage,
> which just handles this under the covers

There should be none, we don't even expose the raw data.

[WebKit Commit Bot]

Comment on attachment 318948 [details]
Patch

Clearing flags on attachment: 318948

Committed r221149: <http://trac.webkit.org/changeset/221149>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.