Bug 175896 – Add WKUIDelegatePrivate callbacks corresponding to WKPageUIClient's takeFocus, focus, and unfocus

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Add WKUIDelegatePrivate callbacks corresponding to WKPageUIClient's takeFocus, focus, and unfocus

[Alex Christensen]

Created attachment 318893 [details]
Patch

[Tim Horton]

Comment on attachment 318893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318893&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:130
> -- (void)_webViewShow:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA));
> +- (void)_showWebView:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA));
> +- (void)_focusWebView:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA));
> +- (void)_unfocusWebView:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA));
> +- (void)_webView:(WKWebView *)webView takeFocus:(_WKFocusDirection)direction WK_API_AVAILABLE(macosx(WK_MAC_TBA));

I have another question. Why are all these things Mac only? They don't seem to be, underneath. Platform-specific things should be the exception, not the rule.

[Alex Christensen]

Created attachment 318901 [details]
Patch

[Alex Christensen]

(In reply to Tim Horton from comment #2)
> I have another question. Why are all these things Mac only? They don't seem
> to be, underneath. Platform-specific things should be the exception, not the
> rule.
Focus and keyboard events are quite different on iOS.  _webViewShow didn't work on iOS and it's not needed.  We could fix it and add it later if needed.

[Alex Christensen]

Created attachment 318906 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r221099

[Radar WebKit Bug Importer]

<rdar://problem/34042618>

[Alex Christensen]

rdar://problem/29270035