Bug 175893 - DFG::JITCode::osrEntry should get sorted since we perform a binary search on it
Summary: DFG::JITCode::osrEntry should get sorted since we perform a binary search on it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on: 175973
Blocks:
  Show dependency tree / graph
 
Reported: 2017-08-23 11:14 PDT by Saam Barati
Modified: 2017-08-25 12:12 PDT (History)
13 users (show)

See Also:

Attachments
patch (3.32 KB, patch)
2017-08-23 23:39 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
re-landing patch (3.31 KB, patch)
2017-08-25 11:29 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-08-23 11:14:07 PDT 
I think right now we're probably just lucky that it often ends up in a sorted manner because of sensible program order. But I don't see any way we ensure this, so we should explicitly sort it.
Comment 1 Saam Barati 2017-08-23 22:54:28 PDT 
Hmm, it seems like zero jsc tests end up with an unsorted vector. Maybe I'm missing something.
Comment 2 Saam Barati 2017-08-23 23:23:19 PDT 
Ok, there is definitely no reason we should be seeing them already sorted. We're just getting lucky. Ima add code that sorts them.
Comment 3 Saam Barati 2017-08-23 23:39:23 PDT 
Created attachment 318970 [details]
patch
Comment 4 Mark Lam 2017-08-24 09:28:47 PDT 
Comment on attachment 318970 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2017-08-24 09:59:03 PDT 
Comment on attachment 318970 [details]
patch

Clearing flags on attachment: 318970

Committed r221143: <http://trac.webkit.org/changeset/221143>
Comment 6 WebKit Commit Bot 2017-08-24 09:59:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-24 09:59:42 PDT 
<rdar://problem/34060471>
Comment 8 WebKit Commit Bot 2017-08-24 18:53:16 PDT 
Re-opened since this is blocked by bug 175973
Comment 9 Saam Barati 2017-08-25 11:29:20 PDT 
Created attachment 319089 [details]
re-landing patch
Comment 10 WebKit Commit Bot 2017-08-25 12:12:41 PDT 
Comment on attachment 319089 [details]
re-landing patch

Clearing flags on attachment: 319089

Committed r221200: <http://trac.webkit.org/changeset/221200>
Comment 11 WebKit Commit Bot 2017-08-25 12:12:43 PDT 
All reviewed patches have been landed.  Closing bug.