Bug 175889 - Fix -Wcast-qual warnings in JavaScriptCore with new clang compiler
Summary: Fix -Wcast-qual warnings in JavaScriptCore with new clang compiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-23 10:37 PDT by David Kilzer (:ddkilzer)
Modified: 2017-08-23 13:14 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.88 KB, patch)
2017-08-23 10:47 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-08-23 10:37:24 PDT 
A new clang compiler has stricter -Wcast-qual warnings, so there are a couple places where we need to cast differently.

Tracked by <rdar://problem/33667497>, but there will be multiple bugs filed to fix this, so I'm not adding "InRadar" keyword.
Comment 1 David Kilzer (:ddkilzer) 2017-08-23 10:42:29 PDT 
<rdar://problem/33667497>
Comment 2 David Kilzer (:ddkilzer) 2017-08-23 10:44:31 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #0)
> Tracked by <rdar://problem/33667497>, but there will be multiple bugs filed
> to fix this, so I'm not adding "InRadar" keyword.

Except a radar will be created automatically when this bug is fixed, so adding it anyway.
Comment 3 David Kilzer (:ddkilzer) 2017-08-23 10:47:32 PDT 
Created attachment 318884 [details]
Patch
Comment 4 Mark Lam 2017-08-23 10:51:18 PDT 
Comment on attachment 318884 [details]
Patch

r=me if EWS is happy.
Comment 5 WebKit Commit Bot 2017-08-23 13:14:41 PDT 
Comment on attachment 318884 [details]
Patch

Clearing flags on attachment: 318884

Committed r221097: <http://trac.webkit.org/changeset/221097>
Comment 6 WebKit Commit Bot 2017-08-23 13:14:43 PDT 
All reviewed patches have been landed.  Closing bug.