This will allow splitting CacheStorageEngine implementation in smaller more manageable files
Created attachment 318877 [details] Patch
Comment on attachment 318877 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318877&action=review > Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:37 > + uint64_t identifier; This could have a default initializer, too.
Created attachment 318883 [details] Patch for landing
Thanks for the review. (In reply to Alex Christensen from comment #2) > Comment on attachment 318877 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318877&action=review > > > Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.h:37 > > + uint64_t identifier; > > This could have a default initializer, too. Done
Comment on attachment 318877 [details] Patch Can we make this a sub-namespace of WebCore so we don't have to Webcore::?
(In reply to Geoffrey Garen from comment #5) > Comment on attachment 318877 [details] > Patch > > Can we make this a sub-namespace of WebCore so we don't have to Webcore::? I plan to unify WebCore CacheStorageConnection and WebKit CacheStorageEngine declarations. That will probably mean doing what you suggest. WebCore has a CacheStorage class so we might want to pick a different name for this namespace. Not sure what is best here, maybe CacheAPI?
> WebCore has a CacheStorage class so we might want to pick a different name > for this namespace. > Not sure what is best here, maybe CacheAPI? Maybe DOMCache? We often prefix generic DOM API names with "DOM". Search for files beginning with "DOM" and you'll see lots of examples. DOMMatrix, DOMURL, DOMWindow, etc.
Comment on attachment 318883 [details] Patch for landing Rejecting attachment 318883 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 318883, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 221084 = 1903c78e15a8e72758925da3b9f7b04e15f94b25 r221085 = ec9d3e1d36d094891e4287fa2d96a4ddf080ea68 r221086 = a480fc02bee91b1bdb9c7aa0abdc6e3089431179 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/4369417
DOMCache seems good to me.
Comment on attachment 318883 [details] Patch for landing Rejecting attachment 318883 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 318883, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: patching file Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.cpp patching file Source/WebKit/WebKit.xcodeproj/project.pbxproj patching file Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp patching file Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h patching file Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.messages.in Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4369451
Created attachment 318894 [details] Patch for landing
Comment on attachment 318894 [details] Patch for landing Clearing flags on attachment: 318894 Committed r221093: <http://trac.webkit.org/changeset/221093>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34041453>