Bug 175884 – [Cache API] UIProcess should provide the directory path where to store Cache Storage data

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

And its sandbox extension as well.

[youenn fablet]

Created attachment 318870 [details]
Patch

[youenn fablet]

Created attachment 318874 [details]
Patch

[Brady Eidson]

Comment on attachment 318874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318874&action=review

R+ with comments

> Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:43
> +WK_EXPORT WKStringRef WKContextConfigurationCopyCacheStorageDirectory(WKContextConfigurationRef configuration);
> +WK_EXPORT void WKContextConfigurationSetCacheStorageDirectory(WKContextConfigurationRef configuration, WKStringRef cacheStorageDirectory);
> +

Since there's no tests and therefore no user of this API, just skip it in this patch.

When we do need to expose the API to set the directory, please do so on WKProcessPool instead.

The C-API should be a dead man walking at this point.

> Source/WebKit/UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:58
> +String WebsiteDataStore::defaultCacheStorageDirectory()
> +{
> +    return cacheDirectoryFileSystemRepresentation("CacheStorage");
> +}

I know you're not using this yet, but probably plan to soon.

That said, cacheDirectoryFileSystemRepresentation() is wrong as it picks a directory in the NSCachesDirectory folder.

I think we want websiteDataDirectoryFileSystemRepresentation() instead

[youenn fablet]

Created attachment 319040 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 319040 [details]
Patch for landing

Clearing flags on attachment: 319040

Committed r221175: <http://trac.webkit.org/changeset/221175>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34072441>

[youenn fablet]

Reopening to attach new patch.

[youenn fablet]

Created attachment 319082 [details]
Fixing typo

[WebKit Commit Bot]

Comment on attachment 319082 [details]
Fixing typo

Clearing flags on attachment: 319082

Committed r221190: <http://trac.webkit.org/changeset/221190>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.