Bug 175870 - [GTK] webkit_web_resource_get_data_finish() returns NULL without setting the error
Summary: [GTK] webkit_web_resource_get_data_finish() returns NULL without setting the ...
Status: RESOLVED DUPLICATE of bug 177107
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Nobody
Depends on:
Reported: 2017-08-22 20:25 PDT by Xiang Fan
Modified: 2017-10-04 03:44 PDT (History)
3 users (show)

See Also:

Backtrace (8.71 KB, text/plain)
2017-08-25 21:14 PDT, Michael Catanzaro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xiang Fan 2017-08-22 20:25:59 PDT
webkit_web_resource_get_data_finish() sometimes returns NULL without setting the error, causing a NULL dereference.

Because of this bug, Epiphany crashes if the user saves some special pages.

WebkitGTK+ version: 2.16.6

Error code:

Example website that crashes Epiphany when saved:

Downstream bug:
Comment 1 Michael Catanzaro 2017-08-23 07:01:47 PDT
I can reproduce this crash always if I use the Save Page As context menu item. It works fine if I use Save Video As. Thanks for reporting and for finding a reproducer!
Comment 2 Michael Catanzaro 2017-08-25 21:14:12 PDT
Created attachment 319131 [details]
Comment 3 Michael Catanzaro 2017-08-25 21:23:21 PDT
Looks like webkit_web_resource_get_data() never sets any error. At the very least we need to return some generic error there.

Then the next question is why the resource load is failing in the first place, but that is a separate bug.
Comment 4 Carlos Garcia Campos 2017-10-04 03:44:42 PDT

*** This bug has been marked as a duplicate of bug 177107 ***