Bug 175853 - [Win] Compile error, include file <wtf/AVFoundationHeaderDetection.h> is not found.
Summary: [Win] Compile error, include file <wtf/AVFoundationHeaderDetection.h> is not ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-22 15:09 PDT by Per Arne Vollan
Modified: 2017-08-23 09:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.45 KB, patch)
2017-08-22 15:19 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-08-22 15:09:12 PDT
wtf/Platform.h(1071): fatal error C1083: Cannot open include file: 'wtf/AVFoundationHeaderDetection.h': No such file or directory.

This happens when building WebKit from the .proj files.
Comment 1 Per Arne Vollan 2017-08-22 15:10:04 PDT
<rdar://problem/33960828>
Comment 2 Per Arne Vollan 2017-08-22 15:19:22 PDT
Created attachment 318805 [details]
Patch
Comment 3 Brent Fulgham 2017-08-22 15:20:36 PDT
Comment on attachment 318805 [details]
Patch

I think this may also fix my new build failure caused by using another WTF file in WebCore builds. r=me if EWS passes.
Comment 4 Per Arne Vollan 2017-08-22 15:30:05 PDT
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 318805 [details]
> Patch
> 
> I think this may also fix my new build failure caused by using another WTF
> file in WebCore builds. r=me if EWS passes.

Thanks for reviewing, Brent!

Also, it seems to me that the file preBuild.cmd in WTF is not executed. Is this relevant to the build errors we are seeing?
Comment 5 Brent Fulgham 2017-08-22 15:33:31 PDT
(In reply to Per Arne Vollan from comment #4)
> (In reply to Brent Fulgham from comment #3)
> > Comment on attachment 318805 [details]
> > Patch
> > 
> > I think this may also fix my new build failure caused by using another WTF
> > file in WebCore builds. r=me if EWS passes.
> 
> Thanks for reviewing, Brent!
> 
> Also, it seems to me that the file preBuild.cmd in WTF is not executed. Is
> this relevant to the build errors we are seeing?

Yes, I think so. Though I realize now that your change was only about the *.proj file, so not really relevant here.

Can you try doing a clean build and see if you hit the error? I believe the FORWARDING_HEADERS are not getting copied (since that script no longer runs) causing build failures.
Comment 6 WebKit Commit Bot 2017-08-23 09:21:46 PDT
Comment on attachment 318805 [details]
Patch

Clearing flags on attachment: 318805

Committed r221076: <http://trac.webkit.org/changeset/221076>
Comment 7 WebKit Commit Bot 2017-08-23 09:21:48 PDT
All reviewed patches have been landed.  Closing bug.