Bug 175827 - Add sanity check for source origin in WebLoaderStrategy::startPingLoad()
Summary: Add sanity check for source origin in WebLoaderStrategy::startPingLoad()
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-22 10:24 PDT by Chris Dumez
Modified: 2017-08-22 13:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2017-08-22 10:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.36 KB, patch)
2017-08-22 10:34 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-08-22 10:24:43 PDT 
Add sanity check for source origin in WebLoaderStrategy::startPingLoad().
Comment 1 Chris Dumez 2017-08-22 10:26:10 PDT 
Created attachment 318762 [details]
Patch
Comment 2 Geoffrey Garen 2017-08-22 10:29:56 PDT 
Comment on attachment 318762 [details]
Patch

r=me
Comment 3 youenn fablet 2017-08-22 10:31:25 PDT 
Origin header might not always be there for same-origin requests.
Comment 4 Chris Dumez 2017-08-22 10:34:28 PDT 
Created attachment 318763 [details]
Patch
Comment 5 WebKit Commit Bot 2017-08-22 11:16:43 PDT 
Comment on attachment 318763 [details]
Patch

Clearing flags on attachment: 318763

Committed r221027: <http://trac.webkit.org/changeset/221027>
Comment 6 WebKit Commit Bot 2017-08-22 11:16:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-22 11:17:31 PDT 
<rdar://problem/34016866>
Comment 8 Ryan Haddad 2017-08-22 13:53:24 PDT 
Reverted r221027 for reason:

This change caused LayoutTests to exit early with assertion failures.

Committed r221043: <http://trac.webkit.org/changeset/221043>
Comment 9 Ryan Haddad 2017-08-22 13:54:00 PDT 
(In reply to Ryan Haddad from comment #8)
> Reverted r221027 for reason:
> 
> This change caused LayoutTests to exit early with assertion failures.
> 
> Committed r221043: <http://trac.webkit.org/changeset/221043>
Relevant link:
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r221029%20(2653)/results.html