Bug 175813 - Performance Dashboard should be compatible with PHP 7.
Summary: Performance Dashboard should be compatible with PHP 7.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2017-08-21 23:04 PDT by dewei_zhu
Modified: 2017-08-22 17:21 PDT (History)
3 users (show)

See Also:

Patch (13.53 KB, patch)
2017-08-21 23:10 PDT, dewei_zhu
no flags Details | Formatted Diff | Diff
Patch (11.90 KB, patch)
2017-08-22 15:20 PDT, dewei_zhu
rniwa: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-elcapitan (1.93 MB, application/zip)
2017-08-22 17:21 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2017-08-21 23:04:39 PDT
Performance Dashboard should be compatible with PHP 7.
Comment 1 dewei_zhu 2017-08-21 23:10:59 PDT
Created attachment 318739 [details]
Comment 2 Ryosuke Niwa 2017-08-21 23:36:22 PDT
Comment on attachment 318739 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=318739&action=review

r- because I don't think we should be asking people to override config.json like this.

> Websites/perf.webkit.org/ReadMe.md:52
> +(If you have a PHP 7 installed, please make sure `phpVersion` in `config.json` is updated to 'PHP7', by default it's 'PHP5'.
> +)

I don't think should force everyone to manually edit JSON like this.

> Websites/perf.webkit.org/config.json:27
> +        "httpdMutexDir": "/tmp/org.webkit.perf.tests/",
> +        "phpVersion": "PHP5"

Instead of specifying PHP version like that, we should just pick the right module based on the result of php -v.

> Websites/perf.webkit.org/server-tests/resources/test-server.js:173
> +        let phpVersion = Config.value('testServer.phpVersion');

Just do: ChildProcess.execFileSync('php', ['-v']).includes('PHP 5') ? 'PHP5' : 'PHP7';
Comment 3 dewei_zhu 2017-08-22 15:20:59 PDT
Created attachment 318806 [details]
Comment 4 Ryosuke Niwa 2017-08-22 15:48:28 PDT
Comment on attachment 318806 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=318806&action=review

> Websites/perf.webkit.org/tools/remote-server-relay.conf:66
> +<IfModule php5_module>

Change this to php7_module.
Comment 5 Build Bot 2017-08-22 17:21:44 PDT
Comment on attachment 318806 [details]

Attachment 318806 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4364601

New failing tests:
Comment 6 Build Bot 2017-08-22 17:21:45 PDT
Created attachment 318831 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6