Make generate_offset_extractor.rb architetures argument more robust
Created attachment 318726 [details] Patch
Comment on attachment 318726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318726&action=review > Source/JavaScriptCore/ChangeLog:3 > + Make generate_offset_extractor.rb architetures argument more robust Typo in bug name: architetures > Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:42 > -validBackends = canonicalizeBackendNames(ARGV.shift.split(",")) > +validBackends = canonicalizeBackendNames(ARGV.shift.split(/,+\s*|\s+/)) How about: /[,\s]+/ This to require any combination of spaces and commas. Your regex supports leading commands and trailing whitespace but not emptiness in-between, which seems weird.
Comment on attachment 318726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318726&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + Make generate_offset_extractor.rb architetures argument more robust > > Typo in bug name: architetures Whoops fixed. >> Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:42 >> +validBackends = canonicalizeBackendNames(ARGV.shift.split(/,+\s*|\s+/)) > > How about: > > /[,\s]+/ > > This to require any combination of spaces and commas. Your regex supports leading commands and trailing whitespace but not emptiness in-between, which seems weird. Yeah, that's a better Regex! I'll change.
Committed r221000: <http://trac.webkit.org/changeset/221000>
<rdar://problem/34006009>