Bug 175799 - [WPE][GTK] Unused variables in UserMediaProcessManager.cpp
Summary: [WPE][GTK] Unused variables in UserMediaProcessManager.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
Keywords: InRadar
Depends on:
Reported: 2017-08-21 17:19 PDT by Adrian Perez
Modified: 2017-08-21 18:15 PDT (History)
5 users (show)

See Also:

Patch (1.43 KB, patch)
2017-08-21 17:23 PDT, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-08-21 17:19:59 PDT
Building the GTK+ port (or the WPE one) with Clang results in:

  ../../Source/WebKit/UIProcess/UserMediaProcessManager.cpp:33:26: warning: unused variable 'audioExtensionPath' [-Wunused-const-variable]
  static const char* const audioExtensionPath = "com.apple.webkit.microphone";
  ../../Source/WebKit/UIProcess/UserMediaProcessManager.cpp:34:26: warning: unused variable 'videoExtensionPath' [-Wunused-const-variable]
  static const char* const videoExtensionPath = "com.apple.webkit.camera";
  2 warnings generated.

These variables should be guarded by “#if ENABLE(SANDBOX_EXTENSIONS)”.
Comment 1 Adrian Perez 2017-08-21 17:23:56 PDT
Created attachment 318704 [details]
Comment 2 WebKit Commit Bot 2017-08-21 18:14:18 PDT
Comment on attachment 318704 [details]

Clearing flags on attachment: 318704

Committed r220995: <http://trac.webkit.org/changeset/220995>
Comment 3 WebKit Commit Bot 2017-08-21 18:14:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-08-21 18:15:28 PDT