The following warning is generated when building with Clang: In file included from ../../Source/WebCore/platform/graphics/MediaPlayer.cpp:55: In file included from ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:30: ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:152:45: warning: 'proxy' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] RefPtr<TextureMapperPlatformLayerProxy> proxy() const; ^ ../../Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyProvider.h:36:53: note: overridden virtual function is here virtual RefPtr<TextureMapperPlatformLayerProxy> proxy() const = 0; ^
Created attachment 318660 [details] Patch
Comment on attachment 318660 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318660&action=review > Source/WebCore/ChangeLog:3 > + [GTK][WPE][GSTREAMER_GL] [GTK][WPE] Overriden virtual function not marked âoverrideâ in MediaPlayerPrivateGStreamerBase.h ETOOMANYTAGS
(In reply to Konstantin Tokarev from comment #2) > Comment on attachment 318660 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318660&action=review > > > Source/WebCore/ChangeLog:3 > > + [GTK][WPE][GSTREAMER_GL] [GTK][WPE] Overriden virtual function not marked âoverrideâ in MediaPlayerPrivateGStreamerBase.h > > ETOOMANYTAGS Ouch, I'll remove the extra tags before landing. Thanks!
Committed r220978: <http://trac.webkit.org/changeset/220978>
<rdar://problem/33997746>