RESOLVED FIXED 175768
media-captions.html improvements 
https://bugs.webkit.org/show_bug.cgi?id=175768
Summary media-captions.html improvements
Ms2ger (he/him; ⌚ UTC+1/+2)
Reported 2017-08-21 07:01:52 PDT
.
Attachments
Patch (1.83 KB, patch)
2017-08-21 07:04 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2017-08-21 07:04:32 PDT
Created attachment 318630 [details] Patch
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 2 2017-08-21 07:04:46 PDT
For the record, the failure on GTK is --- media-captions-expected.txt +++ media-captions-actual.txt @@ -18,10 +18,10 @@ EVENT(loadstart) EVENT(durationchange) EVENT(canplaythrough) -EXPECTED (mediaElement.webkitHasClosedCaptions == 'true') OK +EXPECTED (mediaElement.webkitHasClosedCaptions == 'true'), OBSERVED 'false' FAIL EXPECTED (mediaElement.webkitClosedCaptionsVisible == 'false') OK *** enabling captions -EXPECTED (mediaElement.webkitClosedCaptionsVisible == 'true') OK +EXPECTED (mediaElement.webkitClosedCaptionsVisible == 'true'), OBSERVED 'false' FAIL END OF TEST
WebKit Commit Bot
Comment 3 2017-08-21 08:44:31 PDT
Comment on attachment 318630 [details] Patch Clearing flags on attachment: 318630 Committed r220965: <http://trac.webkit.org/changeset/220965>
WebKit Commit Bot
Comment 4 2017-08-21 08:44:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-08-21 08:45:37 PDT
<rdar://problem/33992226>
Note You need to log in before you can comment on or make changes to this bug.