Bug 175761 – [EME] HTMLMediaElement: basic implementations of 'Attempt to Decrypt', 'Attempt to Resume Playback If Necessary'

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[EME] HTMLMediaElement: basic implementations of 'Attempt to Decrypt', 'Attempt to Resume Playback If Necessary'

[Zan Dobersek]

Created attachment 318617 [details]
Patch

[Build Bot]

Attachment 318617 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp:140:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Xabier Rodríguez Calvar]

Comment on attachment 318617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318617&action=review

> Source/WebCore/ChangeLog:15
> +        the platform layer. The gist of the algorithm is to invoke the decryption

gist?

> Source/WebCore/ChangeLog:17
> +        retrieved from the MediaKeys object that's associated with this media

I've never seen that's contracted when that is the subordinate pronoun, but I might be wrong...

> Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp:140
> +        [](auto& session) { return !session->isClosed(); });

Fix the style checker complain. And it looks like you should leave a space between the [] and the (

[Zan Dobersek]

Created attachment 318628 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 318628 [details]
Patch for landing

Clearing flags on attachment: 318628

Committed r220962: <http://trac.webkit.org/changeset/220962>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33990737>

[Michael Catanzaro]

(In reply to Xabier Rodríguez Calvar from comment #3)
> > Source/WebCore/ChangeLog:15
> > +        the platform layer. The gist of the algorithm is to invoke the decryption
> 
> gist?

It means "the general idea" (of the algorithm).

> I've never seen that's contracted when that is the subordinate pronoun, but
> I might be wrong...

It's fine!