Bug 175756 - Simplify calls to LoaderStrategy::startPingLoad()
Summary: Simplify calls to LoaderStrategy::startPingLoad()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Blocks: 175746
  Show dependency treegraph
Reported: 2017-08-20 11:03 PDT by Chris Dumez
Modified: 2017-08-20 18:39 PDT (History)
10 users (show)

See Also:

Patch (16.07 KB, patch)
2017-08-20 13:40 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-08-20 11:03:40 PDT
Simplify calls to LoaderStrategy::startPingLoad().
Comment 1 Chris Dumez 2017-08-20 13:40:04 PDT
Created attachment 318605 [details]
Comment 2 WebKit Commit Bot 2017-08-20 16:11:44 PDT
Comment on attachment 318605 [details]

Clearing flags on attachment: 318605

Committed r220957: <http://trac.webkit.org/changeset/220957>
Comment 3 WebKit Commit Bot 2017-08-20 16:11:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-08-20 16:12:19 PDT
Comment 5 youenn fablet 2017-08-20 18:39:40 PDT
Comment on attachment 318605 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=318605&action=review

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:425
> +    loadParameters.sourceOrigin = &document->securityOrigin();

Since we have both request and sourceOrigin, I wonder whether we should not add an ASSERT ensuring that the Origin header of the request, if any, is matching sourceOrigin.
And maybe one for referer as well.

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:432
> +        if (auto * contentSecurityPolicy = document->contentSecurityPolicy())

space between auto and *.